Add ResponseData to __all__#270
Merged
Merged
Conversation
mdegat01
added
the
refactor
Collaborator
Author
|
@agners one of the very few PRs where I've felt "hm, maybe the chore label fits best" 😆 |
21 tasks
frenck
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
In home-assistant/core#164413 I needed to gather results from several APIs at once and then the only method needed for each was
to_dict. This meant proper typing would be to uselist[ResponseData]. Since it is useful to gather like this at times that type should be added to__all__