Skip to content

Add static routes for frontend modern and legacy service workers#120488

Merged
bramkragten merged 1 commit intohome-assistant:devfrom
steverep:legacy-service-worker
Jul 19, 2024
Merged

Add static routes for frontend modern and legacy service workers#120488
bramkragten merged 1 commit intohome-assistant:devfrom
steverep:legacy-service-worker

Conversation

@steverep
Copy link
Copy Markdown
Member

@steverep steverep commented Jun 26, 2024

Proposed change

Update paths for service worker to reflect enabling it on the legacy build. Also adds routes for the source maps. Frontend PR home-assistant/frontend#21177 must be incorporated into core for tests to pass again.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/frontend, mind taking a look at this pull request as it has been labeled with an integration (frontend) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of frontend can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign frontend Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@steverep steverep marked this pull request as ready for review June 26, 2024 20:38
@steverep steverep force-pushed the legacy-service-worker branch from f374cef to 212ef8e Compare June 29, 2024 22:05
@frenck frenck force-pushed the legacy-service-worker branch from 212ef8e to 370cb76 Compare July 7, 2024 20:48
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Awaiting frontend.

../Frenck

@bramkragten bramkragten merged commit e50802a into home-assistant:dev Jul 19, 2024
@MartinHjelmare
Copy link
Copy Markdown
Member

Looks like this was merged with a failing test.

@silamon
Copy link
Copy Markdown
Contributor

silamon commented Jul 19, 2024

Frontend PR home-assistant/frontend#21177 must be incorporated into core for tests to pass again.

It's mentioned in the description:
Frontend PR home-assistant/frontend#21177 must be incorporated into core for tests to pass again.
So a new frontend release must be made.

@MartinHjelmare
Copy link
Copy Markdown
Member

I'd expect this PR to have contained the frontend bump before merge so that we can see that tests pass. That's our normal procedure when a requirement bump needs additional changes. They all go in the same PR.

@bramkragten
Copy link
Copy Markdown
Member

Sorry @MartinHjelmare was a little too quick, will revert and do it properly

bramkragten added a commit that referenced this pull request Jul 19, 2024
bramkragten added a commit that referenced this pull request Jul 19, 2024
@steverep steverep deleted the legacy-service-worker branch July 19, 2024 14:29
@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants