iaqualink: add initial quality scale assessment#167738
iaqualink: add initial quality scale assessment#167738flz wants to merge 11 commits intohome-assistant:devfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an initial Integration Quality Scale (IQS) assessment for the iaqualink integration and updates hassfest so the new assessment file is recognized.
Changes:
- Remove
iaqualinkfrom hassfest’s “missing quality scale file” allowlist. - Add
homeassistant/components/iaqualink/quality_scale.yamlwith an initial set of rule statuses (done/todo/exempt).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
script/hassfest/quality_scale.py |
Stops treating iaqualink as an integration without a quality_scale.yaml. |
homeassistant/components/iaqualink/quality_scale.yaml |
Introduces the integration’s initial IQS self-assessment ruleset. |
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Thanks for the quick review! Given there are only two todo's for Bronze, I'll leave this PR as Draft as someone suggested on Discord and submit two PRs to address the fixes. When merged, I'll update this one but bump the integration quality level to Bronze. |
Co-authored-by: Ariel Ebersberger <31776703+justanotherariel@users.noreply.github.com>
Co-authored-by: Ariel Ebersberger <31776703+justanotherariel@users.noreply.github.com>
home-assistant#167931 and home-assistant/home-assistant.io#44648 Co-authored-by: Florent Thoumie <flz@xbsd.org>
| discovery-update-info: | ||
| status: exempt | ||
| comment: This integration has no supported discovery mechanism. | ||
| discovery: | ||
| status: exempt | ||
| comment: This integration has no supported discovery mechanism. |
There was a problem hiding this comment.
Why not? Did you check mDNS or DHCP? what is the mac address and what is the hostname?
There was a problem hiding this comment.
No mDNS that I could see.
I didn't see discovery mechanism based on MAC (not sure how reliable it would be given there's a few different products by different manufacturers) or DHCP. Any good integration examples?
| action-exceptions: | ||
| status: exempt | ||
| comment: This integration does not register integration actions. |
There was a problem hiding this comment.
turning on a light or climate also is an action
There was a problem hiding this comment.
I thought it was for integration-specific actions?
There was a problem hiding this comment.
Documentation says no exception but I'm not sure what should go in that part of the documentation?
There was a problem hiding this comment.
I think I should reword it better, but the built in actions that can raise also should be handled well
There was a problem hiding this comment.
Exceptions were already largely handled by I found some inconsistent handling, opened a PR here: #168268
Breaking change
Proposed change
Add initial quality scale assessment for iaqualink integration.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: