Skip to content

iaqualink: add initial quality scale assessment#167738

Draft
flz wants to merge 11 commits intohome-assistant:devfrom
flz:iaqualink-scale
Draft

iaqualink: add initial quality scale assessment#167738
flz wants to merge 11 commits intohome-assistant:devfrom
flz:iaqualink-scale

Conversation

@flz
Copy link
Copy Markdown
Contributor

@flz flz commented Apr 9, 2026

Breaking change

Proposed change

Add initial quality scale assessment for iaqualink integration.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an initial Integration Quality Scale (IQS) assessment for the iaqualink integration and updates hassfest so the new assessment file is recognized.

Changes:

  • Remove iaqualink from hassfest’s “missing quality scale file” allowlist.
  • Add homeassistant/components/iaqualink/quality_scale.yaml with an initial set of rule statuses (done/todo/exempt).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
script/hassfest/quality_scale.py Stops treating iaqualink as an integration without a quality_scale.yaml.
homeassistant/components/iaqualink/quality_scale.yaml Introduces the integration’s initial IQS self-assessment ruleset.

Copy link
Copy Markdown
Member

@justanotherariel justanotherariel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few remarks

@home-assistant
Copy link
Copy Markdown

home-assistant bot commented Apr 9, 2026

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft April 9, 2026 14:23
Copilot AI review requested due to automatic review settings April 9, 2026 14:28
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@flz
Copy link
Copy Markdown
Contributor Author

flz commented Apr 9, 2026

A few remarks

Thanks for the quick review!

Given there are only two todo's for Bronze, I'll leave this PR as Draft as someone suggested on Discord and submit two PRs to address the fixes. When merged, I'll update this one but bump the integration quality level to Bronze.

Copilot AI review requested due to automatic review settings April 9, 2026 19:54
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings April 11, 2026 15:23
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Copilot AI review requested due to automatic review settings April 12, 2026 15:57
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Copilot AI review requested due to automatic review settings April 14, 2026 16:02
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comment on lines +45 to +50
discovery-update-info:
status: exempt
comment: This integration has no supported discovery mechanism.
discovery:
status: exempt
comment: This integration has no supported discovery mechanism.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not? Did you check mDNS or DHCP? what is the mac address and what is the hostname?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No mDNS that I could see.

I didn't see discovery mechanism based on MAC (not sure how reliable it would be given there's a few different products by different manufacturers) or DHCP. Any good integration examples?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following up here: #168256

@flz flz force-pushed the iaqualink-scale branch from b0155c4 to 7ba2c20 Compare April 14, 2026 16:29
Comment on lines +27 to +29
action-exceptions:
status: exempt
comment: This integration does not register integration actions.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

turning on a light or climate also is an action

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it was for integration-specific actions?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation says no exception but I'm not sure what should go in that part of the documentation?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I should reword it better, but the built in actions that can raise also should be handled well

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exceptions were already largely handled by I found some inconsistent handling, opened a PR here: #168268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants