feat: Introduce resticprofile#1347
Open
charming-byte wants to merge 1 commit intohome-operations:mainfrom
Open
feat: Introduce resticprofile#1347charming-byte wants to merge 1 commit intohome-operations:mainfrom
charming-byte wants to merge 1 commit intohome-operations:mainfrom
Conversation
onedr0p
reviewed
Apr 13, 2026
Contributor
onedr0p
left a comment
onedr0p
left a comment
There was a problem hiding this comment.
Take a look at how all the other images are crafted and see if you can adjust more things to our standards.
| } | ||
|
|
||
| variable "VERSION" { | ||
| // renovate: datasource=docker depName=docker.io/creativeprojects/resticprofile |
Contributor
There was a problem hiding this comment.
The version should come from github-releases
| } | ||
|
|
||
| variable "SOURCE" { | ||
| default = "https://github.com/creativeprojects/resticprofile/" |
Contributor
There was a problem hiding this comment.
Suggested change
| default = "https://github.com/creativeprojects/resticprofile/" | |
| default = "https://github.com/creativeprojects/resticprofile" |
Comment on lines
+1
to
+2
| # syntax=docker/dockerfile:1 | ||
| FROM alpine:latest |
Contributor
There was a problem hiding this comment.
Suggested change
| # syntax=docker/dockerfile:1 | |
| FROM alpine:latest | |
| # syntax=docker/dockerfile:1 | |
| FROM docker.io/library/alpine:3.23 |
Comment on lines
+7
to
+8
| COPY --from=ghcr.io/creativeprojects/resticprofile:latest /usr/bin/restic /usr/bin/restic | ||
| COPY --from=ghcr.io/creativeprojects/resticprofile:latest /usr/bin/rclone /usr/bin/rclone |
Contributor
There was a problem hiding this comment.
These should probably be installed with apk
| tar xvzf /resticprofile.tar.gz -C /usr/bin resticprofile && \ | ||
| rm /resticprofile.tar.gz && \ | ||
| chmod +x /usr/bin/restic /usr/bin/rclone /usr/bin/resticprofile && \ | ||
| adduser -D -h /resticprofile resticprofile && \ |
Contributor
There was a problem hiding this comment.
is adding a user really necessary over using nobody:nogroup?
Comment on lines
+20
to
+22
| USER resticprofile | ||
| VOLUME /resticprofile | ||
| WORKDIR /resticprofile |
Contributor
There was a problem hiding this comment.
Suggested change
| USER resticprofile | |
| VOLUME /resticprofile | |
| WORKDIR /resticprofile | |
| USER nobody:nogroup | |
| WORKDIR /resticprofile | |
| VOLUME ["/resticprofile"] |
or if this could be /config, that would work too
| WORKDIR /resticprofile | ||
|
|
||
| ENTRYPOINT ["resticprofile"] | ||
| CMD ["--help"] No newline at end of file |
Contributor
There was a problem hiding this comment.
This is not helpful, I would create a entrypoint.sh with defaults
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #1346