Skip to content

add websocket server options support for node-ws#1808

Open
rafia9005 wants to merge 3 commits intohonojs:mainfrom
rafia9005:support-websocket-server-options
Open

add websocket server options support for node-ws#1808
rafia9005 wants to merge 3 commits intohonojs:mainfrom
rafia9005:support-websocket-server-options

Conversation

@rafia9005
Copy link
Copy Markdown

@rafia9005 rafia9005 commented Mar 19, 2026

This PR adds support for passing custom WebSocketServer options to createNodeWebSocket, addressing issue #1786.

  • Added websocketServerOptions parameter to NodeWebSocketInit interface
  • Users can now configure WebSocketServer options like maxPayload, perMessageDeflate, clientTracking, etc.
  • The noServer option remains enforced as true internally and cannot be overridden
  • Added comprehensive tests to verify the new functionality
  • Updated README with usage examples and documentation

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 19, 2026

🦋 Changeset detected

Latest commit: 67b0cb1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hono/node-ws Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.73%. Comparing base (af99687) to head (67b0cb1).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1808   +/-   ##
=======================================
  Coverage   91.73%   91.73%           
=======================================
  Files         113      113           
  Lines        3785     3785           
  Branches      957      957           
=======================================
  Hits         3472     3472           
  Misses        281      281           
  Partials       32       32           
Flag Coverage Δ
node-ws 80.89% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant