feat(helm): add label customization option for service#63
Merged
nahidhasan94 merged 2 commits intohoppscotch:mainfrom Apr 10, 2026
Merged
feat(helm): add label customization option for service#63nahidhasan94 merged 2 commits intohoppscotch:mainfrom
nahidhasan94 merged 2 commits intohoppscotch:mainfrom
Conversation
Contributor
Author
|
hey @nahidhasan94, could you have a look at this? |
Collaborator
Sure. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a Helm values hook to allow users to specify custom Kubernetes labels on the generated Service.
Changes:
- Document (commented) example for
service.labelsinvalues.yaml. - Render
service.labelsundermetadata.labelsin the Service template.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| charts/shc/values.yaml | Adds an example showing how to configure custom service labels. |
| charts/shc/templates/service.yaml | Injects Values.service.labels into the Service manifest labels. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
@nahidhasan94 I did apply the suggested fix. can you merge this? |
nahidhasan94
approved these changes
Apr 10, 2026
Collaborator
thanks. done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently it is not possible to set custom labels via the helm chart.
This PR adds that functionality.