Skip to content

Log Controller Not Found when controller is not found. #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ted-Tash wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Log Controller Not Found when controller is not found. #864

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
59c8fb9
Log `controller not found` when controller is not found
Ted-Tash Jan 7, 2026
09c9d6d
tweaking spec
Ted-Tash Jan 8, 2026
b64d625
Removing `else` and using early return for controller when there is one.
Ted-Tash Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/core/application.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,12 @@ export class Application implements ErrorHandler {

getControllerForElementAndIdentifier(element: Element, identifier: string): Controller | null {
const context = this.router.getContextForElementAndIdentifier(element, identifier)
return context ? context.controller : null
if (context) {
return context.controller
} else {
this.logDebugActivity(identifier, "controller not found", { element })
return null
}
}

// Error handling
Expand Down
18 changes: 18 additions & 0 deletions src/tests/modules/core/application_tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,24 @@ export default class ApplicationTests extends ApplicationTestCase {
this.assert.ok(this.controllers[0] instanceof BController)
}

"test Application#getControllerForElementAndIdentifier logs debug activity when controller not found"() {
this.application.load(this.definitions)

const logCalls: { identifier: string; functionName: string; detail: { element?: Element } }[] = []
this.application.logDebugActivity = (identifier, functionName, detail = {}) => {
logCalls.push({ identifier, functionName, detail })
}

const element = this.fixtureElement.querySelector("[data-controller='a']")!
const result = this.application.getControllerForElementAndIdentifier(element, "nonexistent")

this.assert.equal(result, null)
this.assert.equal(logCalls.length, 1)
this.assert.equal(logCalls[0].identifier, "nonexistent")
this.assert.equal(logCalls[0].functionName, "controller not found")
this.assert.equal(logCalls[0].detail.element, element)
}

get controllers() {
return this.application.controllers as LogController[]
}
Expand Down