Skip to content

fix: Upgrade secure storage#804

Open
johannesvedder wants to merge 2 commits into
devfrom
fix/upgrade-secure-storage
Open

fix: Upgrade secure storage#804
johannesvedder wants to merge 2 commits into
devfrom
fix/upgrade-secure-storage

Conversation

@johannesvedder
Copy link
Copy Markdown
Contributor

@johannesvedder johannesvedder commented Mar 23, 2026

This pull request includes several updates across the Android, iOS, and Flutter common modules, focusing on upgrading dependencies, updating environment configuration, and aligning build settings with newer standards.

Build system and dependency upgrades:

  • Upgraded Android build configuration to use Java 17 for both sourceCompatibility, targetCompatibility, and kotlinOptions.jvmTarget in app/android/app/build.gradle.kts. This modernizes the build environment and enables usage of newer Java features.
  • Updated the flutter_secure_storage dependency to version ^10.0.0 in flutter_common/pubspec.yaml, allowing access to bug fixes and new features in the latest releases.
  • Removed commented-out options in the FlutterSecureStorage initialization in flutter_common/lib/src/utils/storage.dart for cleaner and more maintainable code.

Configuration and environment changes:

  • Updated the STUDYU_SUPABASE_PUBLIC_ANON_KEY value in the development environment file flutter_common/lib/envs/.env.dev, likely for security or access reasons.

Platform-specific settings:

  • Removed the MinimumOSVersion key from the iOS AppFrameworkInfo.plist, possibly to inherit the default or configure it elsewhere.

Other minor changes include a formatting adjustment in the German localization Dart file, which does not affect functionality.

@github-actions github-actions Bot added dependencies Pull requests that update a dependency file app flutter_common labels Mar 23, 2026
@github-actions
Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 1a5e261):

(expires Mon, 30 Mar 2026 18:09:32 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2149dad49ed83535217e50d5c18c0c8c90da629b

Copy link
Copy Markdown
Collaborator

@mohiuddinshahrukh mohiuddinshahrukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this locally:

  • flutter_common tests passed.
  • App web debug build passed.
  • Android debug APK build passed.
  • I completed the participant flow.
  • Refreshing the dashboard preserved the active study state.

So other that one thing, everything looks good!

@@ -1,5 +1,5 @@
STUDYU_SUPABASE_URLS=https://studyu-02.dhc-lab.hpi.de
STUDYU_SUPABASE_PUBLIC_ANON_KEY=eyJhbGciOiAiSFMyNTYiLCJ0eXAiOiAiSldUIn0.eyJyb2xlIjogImFub24iLCJpc3MiOiAic3VwYWJhc2UiLCJpYXQiOiAxNzY1MDEzMTIyLCJleHAiOiAxNzk2NTQ5MTIyfQ.d8cyoFZ_E3ymZyKEjZCP1VktnlMFntOaaosSwjjPFMY
STUDYU_SUPABASE_PUBLIC_ANON_KEY=eyJhbGciOiAiSFMyNTYiLCJ0eXAiOiAiSldUIn0.eyJyb2xlIjogImFub24iLCJpc3MiOiAic3VwYWJhc2UiLCJpYXQiOiAxNzU3Mzk3MDI5LCJleHAiOiAxNzg4OTMzMDI5fQ.BQwOLCX6h7RBvZ0xTdt2o-3Hw6YJxalI7EuCVwH69yo
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More of a question from my side:
Was this key rotation intentional and required? If yes: It might be helpful to mention it in the PR description also! ; otherwise my suggestion: It may be cleaner to split it out from the secure-storage upgrade.

Let me know what your thoughts are!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app dependencies Pull requests that update a dependency file flutter_common

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants