fix: Upgrade secure storage#804
Open
johannesvedder wants to merge 2 commits into
Open
Conversation
|
Visit the preview URL for this PR (updated for commit 1a5e261):
(expires Mon, 30 Mar 2026 18:09:32 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2149dad49ed83535217e50d5c18c0c8c90da629b |
mohiuddinshahrukh
approved these changes
Apr 28, 2026
Collaborator
mohiuddinshahrukh
left a comment
There was a problem hiding this comment.
I tested this locally:
flutter_commontests passed.- App web debug build passed.
- Android debug APK build passed.
- I completed the participant flow.
- Refreshing the dashboard preserved the active study state.
So other that one thing, everything looks good!
| @@ -1,5 +1,5 @@ | |||
| STUDYU_SUPABASE_URLS=https://studyu-02.dhc-lab.hpi.de | |||
| STUDYU_SUPABASE_PUBLIC_ANON_KEY=eyJhbGciOiAiSFMyNTYiLCJ0eXAiOiAiSldUIn0.eyJyb2xlIjogImFub24iLCJpc3MiOiAic3VwYWJhc2UiLCJpYXQiOiAxNzY1MDEzMTIyLCJleHAiOiAxNzk2NTQ5MTIyfQ.d8cyoFZ_E3ymZyKEjZCP1VktnlMFntOaaosSwjjPFMY | |||
| STUDYU_SUPABASE_PUBLIC_ANON_KEY=eyJhbGciOiAiSFMyNTYiLCJ0eXAiOiAiSldUIn0.eyJyb2xlIjogImFub24iLCJpc3MiOiAic3VwYWJhc2UiLCJpYXQiOiAxNzU3Mzk3MDI5LCJleHAiOiAxNzg4OTMzMDI5fQ.BQwOLCX6h7RBvZ0xTdt2o-3Hw6YJxalI7EuCVwH69yo | |||
Collaborator
There was a problem hiding this comment.
More of a question from my side:
Was this key rotation intentional and required? If yes: It might be helpful to mention it in the PR description also! ; otherwise my suggestion: It may be cleaner to split it out from the secure-storage upgrade.
Let me know what your thoughts are!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates across the Android, iOS, and Flutter common modules, focusing on upgrading dependencies, updating environment configuration, and aligning build settings with newer standards.
Build system and dependency upgrades:
sourceCompatibility,targetCompatibility, andkotlinOptions.jvmTargetinapp/android/app/build.gradle.kts. This modernizes the build environment and enables usage of newer Java features.flutter_secure_storagedependency to version^10.0.0influtter_common/pubspec.yaml, allowing access to bug fixes and new features in the latest releases.FlutterSecureStorageinitialization influtter_common/lib/src/utils/storage.dartfor cleaner and more maintainable code.Configuration and environment changes:
STUDYU_SUPABASE_PUBLIC_ANON_KEYvalue in the development environment fileflutter_common/lib/envs/.env.dev, likely for security or access reasons.Platform-specific settings:
MinimumOSVersionkey from the iOSAppFrameworkInfo.plist, possibly to inherit the default or configure it elsewhere.Other minor changes include a formatting adjustment in the German localization Dart file, which does not affect functionality.