Add Actions header for the studies table action column#814
Open
mohiuddinshahrukh wants to merge 1 commit into
Open
Add Actions header for the studies table action column#814mohiuddinshahrukh wants to merge 1 commit into
Actions header for the studies table action column#814mohiuddinshahrukh wants to merge 1 commit into
Conversation
Contributor
johannesvedder
left a comment
There was a problem hiding this comment.
Thanks for the idea. I think if the column only contains an ellipsis menu and is not sortable/filterable, we can leave the header visually empty to reduce noise. We still have a tooltip for the menu to provide explanation, so this keeps the table clean without losing clarity
Collaborator
Author
|
Thanks for the feedback. The intention behind this was to follow convention: If all columns have headers, then this should also follow the convention, it makes the table look more aligned but I guess this can be taken as food for thought and considered later on aswell to be something included or left out! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a visible header label for the last column in the studies table so the column purpose is clear.
Changes
designer_v2/lib/features/dashboard/studies_table.dart.StudiesTableColumn.actionheader title toActions.Scope
Validation
Actionsas the last column header.Actionscolumn remains non-sortable.