Skip to content

Adjust New Study button icon spacing and compact sizing#815

Open
mohiuddinshahrukh wants to merge 1 commit into
hpi-studyu:devfrom
mohiuddinshahrukh:fix/new-study-button-icon-spacing
Open

Adjust New Study button icon spacing and compact sizing#815
mohiuddinshahrukh wants to merge 1 commit into
hpi-studyu:devfrom
mohiuddinshahrukh:fix/new-study-button-icon-spacing

Conversation

@mohiuddinshahrukh
Copy link
Copy Markdown
Collaborator

Summary

Refines the New study button on the dashboard toolbar to improve visual balance and spacing while keeping the overall button compact.

Changes

  • Updated designer_v2/lib/common_views/primary_button.dart:
    • Added configurable iconTextSpacing parameter to PrimaryButton.
    • Replaced fixed icon-label gap with iconTextSpacing.
  • Updated designer_v2/lib/features/dashboard/dashboard_page.dart:
    • Applied compact toolbar button sizing for New study:
      • height: 30
      • minimumSize: Size(0, 30)
      • symmetric inner padding (horizontal: 6, vertical: 0)
    • Increased icon/text distance specifically for this button with:
      • iconTextSpacing: 14

Scope

  • UI-only toolbar button polish.
  • No behavior or backend changes.

Validation

  • Verified New study button remains compact.
  • Verified icon and label have clearer separation.
  • Verified button remains aligned with surrounding toolbar elements.

Copy link
Copy Markdown
Contributor

@johannesvedder johannesvedder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old
Image

New
Image

I prefer the old and more rounded button more than the new stretched one to be honest.

@mohiuddinshahrukh
Copy link
Copy Markdown
Collaborator Author

Thank you for the review.

My take on this would be that to make the UI look aligned we either change all the buttons to be following one convention, E.g the filter button looks different from the new study button, (as it should but there should also be some consistency in the system) but the sizes and spacing between icons and texts should be consistent etc.

What do you think about that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants