Adjust New Study button icon spacing and compact sizing#815
Open
mohiuddinshahrukh wants to merge 1 commit into
Open
Adjust New Study button icon spacing and compact sizing#815mohiuddinshahrukh wants to merge 1 commit into
mohiuddinshahrukh wants to merge 1 commit into
Conversation
Collaborator
Author
|
Thank you for the review. My take on this would be that to make the UI look aligned we either change all the buttons to be following one convention, E.g the filter button looks different from the new study button, (as it should but there should also be some consistency in the system) but the sizes and spacing between icons and texts should be consistent etc. What do you think about that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Refines the
New studybutton on the dashboard toolbar to improve visual balance and spacing while keeping the overall button compact.Changes
designer_v2/lib/common_views/primary_button.dart:iconTextSpacingparameter toPrimaryButton.iconTextSpacing.designer_v2/lib/features/dashboard/dashboard_page.dart:New study:height: 30minimumSize: Size(0, 30)horizontal: 6,vertical: 0)iconTextSpacing: 14Scope
Validation
New studybutton remains compact.