Optimize storage slot usage by only computing once - #152
Open
kadenzipfel wants to merge 7 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we used the pattern of
LOAD_ELEMENT_FROM_KEYSthenSTORE_ELEMENT_FROM_KEYSto perform a storage read -> update -> write operation. The problem with this pattern was that bothLOAD_ELEMENT_FROM_KEYSandSTORE_ELEMENT_FROM_KEYScompute the storage slot, meaning that we're computing the slot twice rather than just keeping it on the stackWe optimize this by implementing simple
MAPPING_SLOTmacros inHashmap.huffto simply retrieve the storage slot so that we can keep it on the stack while we read/write to the slot