Skip to content

fix(cli): resolve subpackage register paths before deduplication #2428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Anai-Guo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(cli): resolve subpackage register paths before deduplication #2428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions optimum/commands/optimum_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,16 @@ def load_optimum_namespace_cli_commands() -> (

# Find all registration files and load the commands to register
commands_to_register = []
for register_path in set(commands_register_spec.submodule_search_locations):
register_path = Path(register_path)
# Resolve each path before deduplicating so that symlinked locations collapse to a
# single entry. On RHEL/CentOS-derived distros lib64 is a symlink to lib, so both
# paths appear in submodule_search_locations; plain set() compares strings and
# would treat them as distinct, importing the same register module twice and
# raising "argparse.ArgumentError: conflicting subparser" at CLI startup.
register_paths = {
Path(register_path).resolve()
for register_path in commands_register_spec.submodule_search_locations
}
for register_path in register_paths:
if not register_path.is_dir():
# skip non-directory paths
continue
Expand Down