Skip to content

xet-data: drop sha2/asm to fix v1-resolver Windows breakage #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
assafvayner wants to merge 1 commit into from
Closed

xet-data: drop sha2/asm to fix v1-resolver Windows breakage #833

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions xet_data/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,14 @@ url = { workspace = true }
uuid = { workspace = true, features = ["v7"] }
walkdir = { workspace = true }
pyo3 = { version = "0.26", features = ["abi3-py37"], optional = true }
# Do not enable `sha2/asm`: `sha2-asm` does not support Windows targets, and
# Cargo's v1 feature resolver (used by editions before 2021 / unset
# `resolver`) does not respect target-conditional `cfg(...)` gates around
# feature activations, so a non-Windows-only enablement still leaks the
# feature into Windows builds for downstream consumers. `sha2` already
# runtime-detects SHA-NI via `cpufeatures` independent of the `asm` feature,
# which is the dominant fast path on modern x86 hardware anyway.
sha2 = { workspace = true }

[target.'cfg(target_family = "wasm")'.dependencies]
tokio = { workspace = true, features = [
Expand All @@ -54,12 +62,6 @@ tokio = { workspace = true, features = [
[target.'cfg(not(target_family = "wasm"))'.dependencies]
tokio = { workspace = true, features = ["rt-multi-thread", "rt", "time"] }

[target.'cfg(not(target_os = "windows"))'.dependencies]
sha2 = { workspace = true, features = ["asm"] }

[target.'cfg(target_os = "windows")'.dependencies]
sha2 = { workspace = true }

[[bin]]
name = "x"
path = "src/processing/bin/example.rs"
Expand Down
Loading