Skip to content

Fix fatal error for Post_Meta hook return type #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
r-a-y wants to merge 2 commits into
base: v2.0
Choose a base branch
from
Open

Fix fatal error for Post_Meta hook return type #39

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2be32d5
Fix fatal error for Post_Meta\remove_schedule() return type.
r-a-y Oct 9, 2020
4e27253
Fix fatal error for Post_Meta\update_schedule() return type.
r-a-y Mar 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions inc/post-meta.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,17 +43,17 @@ function register_meta( string $post_type ) : void {
* @param string $meta_key Meta key.
* @param mixed $meta_value Meta value.
*
* @return bool
* @return void
*/
function update_schedule( int $meta_id, int $object_id, string $meta_key, $meta_value ) : bool {
function update_schedule( int $meta_id, int $object_id, string $meta_key, $meta_value ) : void {
if ( $meta_key !== Unpublish\POST_META_KEY ) {
return false;
return;
}

if ( $meta_value ) {
return Unpublish\schedule_unpublish( $object_id, absint( $meta_value ) );
Unpublish\schedule_unpublish( $object_id, absint( $meta_value ) );
} else {
return Unpublish\unschedule_unpublish( $object_id );
Unpublish\unschedule_unpublish( $object_id );
}
}

Expand All @@ -63,15 +63,11 @@ function update_schedule( int $meta_id, int $object_id, string $meta_key, $meta_
* @param int[] $meta_ids An array of deleted metadata entry IDs.
* @param int $object_id Object ID.
* @param string $meta_key Meta key.
*
* @return bool
*/
function remove_schedule( array $meta_ids, int $object_id, string $meta_key ) : bool {
function remove_schedule( array $meta_ids, int $object_id, string $meta_key ) : void {
if ( $meta_key === Unpublish\POST_META_KEY ) {
return Unpublish\unschedule_unpublish( $object_id );
Unpublish\unschedule_unpublish( $object_id );
}

return false;
}

/**
Expand Down