Skip to content

Improve compatibility with exactOptionalPropertyTypes#517

Closed
Stadly wants to merge 4 commits into
huntabyte:mainfrom
Stadly:patch-1
Closed

Improve compatibility with exactOptionalPropertyTypes#517
Stadly wants to merge 4 commits into
huntabyte:mainfrom
Stadly:patch-1

Conversation

@Stadly

@Stadly Stadly commented Apr 26, 2024

Copy link
Copy Markdown
Contributor

This PR fixes the issues described in #516 that I've encountered so far when using shadcn-svelte.

If ok with you, I can create PRs like this as I run into new issues, gradually improving compatibility with exactOptionalPropertyTypes.

@changeset-bot

changeset-bot Bot commented Apr 26, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: e2fd005

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Apr 26, 2024

Copy link
Copy Markdown
Contributor
built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
bits-ui ✅ Ready (View Log) Visit Preview e2fd005

@Stadly

Stadly commented Jul 9, 2024

Copy link
Copy Markdown
Contributor Author

Any thoughts on this, @huntabyte? Would be really helpful.

@daniellovera

Copy link
Copy Markdown

I'm having the same issue. Would be great to get this merged in.

@huntabyte

Copy link
Copy Markdown
Owner

I'm cool with this. We should apply it to all the types though if we're going to do it at all 😃

@Stadly

Stadly commented Jul 20, 2024

Copy link
Copy Markdown
Contributor Author

Would be perfect to have it applied everywhere. I would probably attack the problem with a regex. Any better ideas? Some AST magic?

@Stadly

Stadly commented Jul 27, 2024

Copy link
Copy Markdown
Contributor Author

Superseded by #621.

@Stadly Stadly closed this Jul 27, 2024
@daniellovera

Copy link
Copy Markdown

Saw this was fixed with #621

Good stuff, thanks!

@Stadly Stadly deleted the patch-1 branch July 31, 2024 05:43
@Stadly

Stadly commented Jul 31, 2024

Copy link
Copy Markdown
Contributor Author

Glad to hear it was helpful :) I had to create multiple PRs in order to acheive full compatibility with exactOptionalPropertyTypes for shadcn-svelte:

Hopefully they will all be merged soon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants