Skip to content

[codex] address merged PR review follow-ups #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zhoubot wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[codex] address merged PR review follow-ups #65

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5650be
Address merged PR review follow-ups
Apr 9, 2026
73c4c2b
Format tisa coverage follow-up fix
Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion demos/auto_mode/baseline/add/test/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,11 @@
# See LICENSE in the root of the software repository for the full text of the License.
# --------------------------------------------------------------------------------

import op_extension # noqa: F401
import torch
from torch_npu.testing.testcase import TestCase, run_tests

import op_extension # noqa: F401


class TestCustomAdd(TestCase):
def test_add_custom_ops(self):
Expand Down
2 changes: 1 addition & 1 deletion demos/auto_mode/torch_jit/add/add_compile_and_run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
# --------------------------------------------------------------------------------

import torch
import torch_npu # noqa: F401
import torch_npu # noqa: F401 # Required for NPU backend registration

from jit_util_add import jit_compile

Expand Down
4 changes: 2 additions & 2 deletions tests/cpu/st/testcase/tisa_coverage/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -783,13 +783,13 @@ TEST_F(IsaCoverageTest, ThistogramWrapperBuildsCumulativeBins)
SetValue(src, 0, 6, static_cast<uint16_t>(0x4413u));
SetValue(src, 0, 7, static_cast<uint16_t>(0x2214u));

THISTOGRAM<true>(dst, src, idx);
THISTOGRAM<HistByte::BYTE_1>(dst, src, idx);
EXPECT_EQ(GetValue(dst, 0, 0x11), 0u);
EXPECT_EQ(GetValue(dst, 0, 0x12), 3u);
EXPECT_EQ(GetValue(dst, 0, 0x33), 6u);
EXPECT_EQ(GetValue(dst, 0, 0x34), 7u);

THISTOGRAM<false>(dst, src, idx);
THISTOGRAM<HistByte::BYTE_0>(dst, src, idx);
EXPECT_EQ(GetValue(dst, 0, 0x00), 0u);
EXPECT_EQ(GetValue(dst, 0, 0x01), 1u);
EXPECT_EQ(GetValue(dst, 0, 0x02), 2u);
Expand Down
14 changes: 10 additions & 4 deletions tests/script/all_cpu_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,10 +112,16 @@ def generate_test_data(repo_root: Path, build_dir: Path, args: argparse.Namespac
gen_env["PYTHONPATH"] = str(repo_root) + os.pathsep + gen_env.get("PYTHONPATH", "")
if args.enable_bf16:
gen_env["PTO_CPU_SIM_ENABLE_BF16"] = "1"
for script in sorted(testcase_src_root.glob("*/gen_data.py")):
dst = build_dir / f"{script.parent.name}_gen_data.py"
dst.write_text(script.read_text(encoding="utf-8"), encoding="utf-8")
run_command([sys.executable, str(dst.name)], cwd=build_dir, env=gen_env, verbose=args.verbose)
copied_scripts: list[Path] = []
try:
for script in sorted(testcase_src_root.glob("*/gen_data.py")):
dst = build_dir / f"{script.parent.name}_gen_data.py"
copied_scripts.append(dst)
dst.write_text(script.read_text(encoding="utf-8"), encoding="utf-8")
run_command([sys.executable, str(dst.name)], cwd=build_dir, env=gen_env, verbose=args.verbose)
finally:
for script_path in copied_scripts:
script_path.unlink(missing_ok=True)


def run_binaries(repo_root: Path, build_dir: Path, args: argparse.Namespace) -> int:
Expand Down
Loading