Skip to content

fix: preserve compatibility with old-style A2A3 TPipe local slot arg #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ndleslx wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: preserve compatibility with old-style A2A3 TPipe local slot arg #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions include/pto/npu/a2a3/TPush.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,19 +25,24 @@ enum TSyncCVMode : uint8_t
CV_CORES_SYNC = 2
};

template <uint8_t FlagID, uint8_t DirType, uint32_t SlotSize, uint32_t SlotNum, bool IsNoSplit = false,
uint32_t LocalSlotNum = 2, bool EN_UNIT_FLAG = false>
template <uint8_t FlagID, uint8_t DirType, uint32_t SlotSize, uint32_t SlotNum,
uint32_t CompatLocalSlotNumOrIsNoSplit = 0, uint32_t LocalSlotNum = 2,
bool EN_UNIT_FLAG = false>
struct TPipe {
static constexpr uint8_t DIR_MASK = 0x7;
static constexpr uint8_t DIR_TYPE = DIR_MASK & DirType;
static constexpr bool is_c2v = (DIR_TYPE == Direction::DIR_C2V); // 1
static constexpr bool is_v2c = (DIR_TYPE == Direction::DIR_V2C); // 2
static constexpr bool is_both = (DIR_TYPE == Direction::DIR_BOTH); // 3
static constexpr bool is_v2c_ctrl = (DIR_TYPE == Direction::DIR_V2C_CTRL); // 4
static constexpr bool IsNoSplit =
CompatLocalSlotNumOrIsNoSplit <= 1 && static_cast<bool>(CompatLocalSlotNumOrIsNoSplit);
Comment on lines +38 to +39
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The logic for IsNoSplit can be simplified. Since CompatLocalSlotNumOrIsNoSplit is a uint32_t, the expression CompatLocalSlotNumOrIsNoSplit <= 1 && static_cast<bool>(CompatLocalSlotNumOrIsNoSplit) is logically equivalent to CompatLocalSlotNumOrIsNoSplit == 1. This is more concise and improves readability while maintaining the same behavior (evaluating to true only when the value is 1).

    static constexpr bool IsNoSplit = (CompatLocalSlotNumOrIsNoSplit == 1);

static constexpr uint32_t EffectiveLocalSlotNum =
CompatLocalSlotNumOrIsNoSplit <= 1 ? LocalSlotNum : CompatLocalSlotNumOrIsNoSplit;
static_assert(is_c2v || is_v2c || is_both || is_v2c_ctrl,
"Fix: TPipe only supports C2V or V2C or Both or V2C_CTRL communication on A2A3.");

using RingFiFo = RingFIFO<SlotSize, SlotNum, LocalSlotNum>;
using RingFiFo = RingFIFO<SlotSize, SlotNum, EffectiveLocalSlotNum>;

PTO_INTERNAL static uint64_t getFFTSMsgCfg(TSyncCVMode mode, uint16_t flagID, uint16_t base_const = 0x1)
{
Expand Down