fix(ci): use bash shell for qwen3-decode container step#1101
fix(ci): use bash shell for qwen3-decode container step#1101YunjiQin wants to merge 4 commits intohw-native-sys:mainfrom
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughRemoved the repository's main CI workflow file and updated the Daily CI workflow to run on push/pull_request to Changes
Sequence Diagram(s)(omitted) Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/daily_ci.yml:
- Around line 3-8: The workflow lost its scheduled trigger so the
notify-on-failure step that guards on github.event_name == 'schedule' will never
run; restore a schedule event by adding a schedule: block with a daily cron
(e.g., a single daily cron entry) to the workflow triggers so push/
pull_request/ workflow_dispatch remain and the condition in the
notify-on-failure check (github.event_name == 'schedule') can be satisfied;
update the workflow triggers section (the top-level on: block) to include
schedule alongside push, pull_request and workflow_dispatch.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: bac7546f-be12-4866-84c7-0bd97d693f7f
📒 Files selected for processing (2)
.github/workflows/ci.yml.github/workflows/daily_ci.yml
💤 Files with no reviewable changes (1)
- .github/workflows/ci.yml
5952990 to
72e11df
Compare
The qwen3-decode job runs inside a Docker container where GitHub Actions
defaults to sh (dash). The script uses bash-specific array syntax
(failed=(), failed+=(), ${#failed[@]}) which is invalid in POSIX sh,
causing an immediate "Syntax error: '(' unexpected" failure.
Fixes hw-native-sys#1098
TestMscatter hangs on a5 due to a simpler runtime bug when executing SIMT kernels. Exclude it from daily CI until the upstream fix lands. Refs hw-native-sys#1098
Temporarily replace schedule trigger with push/PR triggers to validate daily CI fixes. Remove ci.yml to avoid running unrelated checks. Will be reverted before merge.
f47d64a to
fd45670
Compare
9c73a2f to
b100627
Compare
Summary
qwen3-decodeDaily CI failure caused by shell incompatibilitysh(dash) which doesn't support bash array syntax (failed=())shell: bashto the "Run qwen3 decode examples" stepFixes #1098
Test plan
workflow_dispatchon Daily CI after merge to verify qwen3-decode passes