Skip to content

fix(ci): use bash shell for qwen3-decode container step#1101

Open
YunjiQin wants to merge 4 commits intohw-native-sys:mainfrom
YunjiQin:issue-1098-fix-qwen3-decode-ci
Open

fix(ci): use bash shell for qwen3-decode container step#1101
YunjiQin wants to merge 4 commits intohw-native-sys:mainfrom
YunjiQin:issue-1098-fix-qwen3-decode-ci

Conversation

@YunjiQin
Copy link
Copy Markdown
Contributor

Summary

  • Fix qwen3-decode Daily CI failure caused by shell incompatibility
  • The container job defaults to sh (dash) which doesn't support bash array syntax (failed=())
  • Added shell: bash to the "Run qwen3 decode examples" step

Fixes #1098

Test plan

  • Trigger workflow_dispatch on Daily CI after merge to verify qwen3-decode passes
  • Alternatively, wait for next scheduled run at UTC 22:00

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 21, 2026

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Removed the repository's main CI workflow file and updated the Daily CI workflow to run on push/pull_request to main (keeps workflow_dispatch), set an explicit bash shell for a qwen3-decode step, and exclude TestMscatter from A5 system-test filters.

Changes

Cohort / File(s) Summary
CI Workflow Removal
\.github/workflows/ci\.yml
Deleted the entire GitHub Actions CI workflow, removing all triggers and jobs (pre-commit, clang-tidy, unit tests on ubuntu/macos, hardware/system tests, A5 simulator tests, and fuzz tests with artifact handling).
Daily CI Trigger & Job Tweaks
\.github/workflows/daily_ci\.yml
Changed trigger from scheduled cron to push/pull_request on main (keeps workflow_dispatch), set shell: bash for the qwen3-decode step, and updated A5 system-tests pytest -k filter to additionally exclude TestMscatter.

Sequence Diagram(s)

(omitted)

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

Suggested reviewers

  • lyfne123
  • Hzfengsy

Poem

🐰
Workflows hop from cron to push,
CI lanes cleared in one swift rush,
A bash set firm, a test now skipped,
Old file gone — the logs unclipped,
Hopping onward, carrots and CI plush.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Out of Scope Changes check ❓ Inconclusive Changes to daily_ci.yml include the bash shell fix for qwen3-decode and TestMscatter exclusion for a5-system-tests, both addressing issue #1098; removal of ci.yml is substantial but appears intentional and related to CI restructuring. Clarify whether the removal of the entire ci.yml workflow was intentional and necessary, as it represents a significant change beyond the qwen3-decode fix described in the PR title and description.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change: adding bash shell specification to the qwen3-decode container step to fix CI failure.
Description check ✅ Passed The description clearly explains the shell incompatibility issue, the fix applied, and references the linked issue #1098.
Linked Issues check ✅ Passed The PR addresses the qwen3-decode job failure from issue #1098 by adding bash shell specification, and also excludes TestMscatter from a5 system tests as referenced in the objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/daily_ci.yml:
- Around line 3-8: The workflow lost its scheduled trigger so the
notify-on-failure step that guards on github.event_name == 'schedule' will never
run; restore a schedule event by adding a schedule: block with a daily cron
(e.g., a single daily cron entry) to the workflow triggers so push/
pull_request/ workflow_dispatch remain and the condition in the
notify-on-failure check (github.event_name == 'schedule') can be satisfied;
update the workflow triggers section (the top-level on: block) to include
schedule alongside push, pull_request and workflow_dispatch.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: bac7546f-be12-4866-84c7-0bd97d693f7f

📥 Commits

Reviewing files that changed from the base of the PR and between ba02283 and e6b602b.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml
  • .github/workflows/daily_ci.yml
💤 Files with no reviewable changes (1)
  • .github/workflows/ci.yml

Comment thread .github/workflows/daily_ci.yml
@YunjiQin YunjiQin mentioned this pull request Apr 21, 2026
@YunjiQin YunjiQin force-pushed the issue-1098-fix-qwen3-decode-ci branch from 5952990 to 72e11df Compare April 22, 2026 09:55
The qwen3-decode job runs inside a Docker container where GitHub Actions
defaults to sh (dash). The script uses bash-specific array syntax
(failed=(), failed+=(), ${#failed[@]}) which is invalid in POSIX sh,
causing an immediate "Syntax error: '(' unexpected" failure.

Fixes hw-native-sys#1098
TestMscatter hangs on a5 due to a simpler runtime bug when executing
SIMT kernels. Exclude it from daily CI until the upstream fix lands.

Refs hw-native-sys#1098
Temporarily replace schedule trigger with push/PR triggers to validate
daily CI fixes. Remove ci.yml to avoid running unrelated checks.

Will be reverted before merge.
@YunjiQin YunjiQin force-pushed the issue-1098-fix-qwen3-decode-ci branch from f47d64a to fd45670 Compare April 23, 2026 01:39
@YunjiQin YunjiQin force-pushed the issue-1098-fix-qwen3-decode-ci branch from 9c73a2f to b100627 Compare April 23, 2026 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

[Daily CI] Failure

1 participant