Skip to content

Fixes to REST API requests #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eroosenmaallen wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixes to REST API requests #8

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e852c89
* _doRestApiRequest: Properly attach request errors to err.allErrors
eroosenmaallen May 3, 2022
4005425
Fixed parameters-in-path
eroosenmaallen May 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lib/mastodon.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,10 @@ Mastodon.prototype._buildReqOpts = function (method, path, params, callback) {
} else {
// Non-file-upload params should be url-encoded
if (Object.keys(finalParams).length > 0) {
reqOpts.url += this.formEncodeParams(finalParams);
if (request === 'GET')
reqOpts.url += this.formEncodeParams(finalParams);
else
reqOpts.body = this.formEncodeParams(finalParams).replace(/^\?/, '');
}
}

Expand Down Expand Up @@ -214,7 +217,8 @@ Mastodon.prototype._doRestApiRequest = function (reqOpts, mastoOptions, method,
// surface this to the caller
var err = helpers.makeMastodonError('JSON decode error: Mastodon HTTP response body was not valid JSON')
err.statusCode = response ? response.statusCode: null;
err.allErrors.concat({error: jsonDecodeError.toString()})
err.allErrors.push({error: jsonDecodeError.toString()});
err.mastodonReply = body;
callback(err, body, response);
return
}
Expand Down