Skip to content

LIKE matches strings containing newlines #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bgmcmullen merged 1 commit into from
Jun 11, 2026
+11 −1
Merged

LIKE matches strings containing newlines #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/expression/binary.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export function applyBinaryOp(op, a, b) {
.replace(/[.*+?^${}()|[\]\\]/g, '\\$&')
.replace(/%/g, '.*')
.replace(/_/g, '.')
const regex = new RegExp(`^${regexPattern}$`, 'i')
const regex = new RegExp(`^${regexPattern}$`, 'is')
return regex.test(str)
}

Expand Down
10 changes: 10 additions & 0 deletions test/execute/execute.where.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,16 @@ describe('WHERE clause', () => {
expect(result.map(r => r.email).sort()).toEqual(['alice@example.com', 'diana@example.com'])
})

it('should filter with LIKE across newlines', async () => {
const data = [
{ id: 1, s: 'line one\nFind me\nline three' },
{ id: 2, s: 'nothing here' },
]
const result = await collect(executeSql({ tables: { data }, query: 'SELECT * FROM data WHERE s LIKE \'%Find me%\'' }))
expect(result).toHaveLength(1)
expect(result.map(r => r.id)).toEqual([1])
})

it('should filter with NOT LIKE', async () => {
const result = await collect(executeSql({ tables: { users }, query: 'SELECT * FROM users WHERE name NOT LIKE \'%li%\'' }))
expect(result).toHaveLength(3)
Expand Down