Skip to content

fix(pds-core): add email label spacing#166

Merged
aspiers merged 1 commit intomainfrom
karma/hyper-386-bug-missing-space-between-account-and-email-address
May 7, 2026
Merged

fix(pds-core): add email label spacing#166
aspiers merged 1 commit intomainfrom
karma/hyper-386-bug-missing-space-between-account-and-email-address

Conversation

@Kzoeps
Copy link
Copy Markdown
Contributor

@Kzoeps Kzoeps commented May 7, 2026

Summary

  • Add a leading space before chooser email labels so handles and email addresses do not run together.
image

Note this is a hotfix and the proper fix is on #148

Testing

  • Not run (PR creation only).

Summary by CodeRabbit

  • Bug Fixes

    • Improved email label display in the chooser enrichment feature to properly handle long email addresses with truncation and ellipsis formatting.
  • Chores

    • Added planning for expanded end-to-end test coverage for consent and chooser enrichment features.

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
epds-demo Ready Ready Preview, Comment May 7, 2026 2:25pm

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 7, 2026

⚠️ No Changeset found

Latest commit: e873e7a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@railway-app
Copy link
Copy Markdown

railway-app Bot commented May 7, 2026

🚅 Deployed to the ePDS-pr-166 environment in ePDS

Service Status Web Updated (UTC)
@certified-app/demo untrusted ✅ Success (View Logs) Web May 7, 2026 at 2:27 pm
@certified-app/pds-core ✅ Success (View Logs) Web May 7, 2026 at 2:27 pm
@certified-app/auth-service ✅ Success (View Logs) Web May 7, 2026 at 2:26 pm
@certified-app/demo ✅ Success (View Logs) Web May 7, 2026 at 2:26 pm

@railway-app railway-app Bot temporarily deployed to ePDS / ePDS-pr-166 May 7, 2026 14:25 Destroyed
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 7, 2026

Review Change Stack

📝 Walkthrough

Walkthrough

The PR improves email display styling in the chooser enrichment browser script by applying CSS truncation constraints to the rendered email label, includes a leading space prefix for the text, and adds an epic issue entry tracking comprehensive E2E coverage goals for consent and chooser enrichment features.

Changes

Chooser Enrichment Display Enhancement

Layer / File(s) Summary
Email Label Display
packages/pds-core/src/chooser-enrichment.ts
Email label <span> now applies style.cssText with truncation rules (min-width:0, white-space:nowrap, overflow:hidden, text-overflow:ellipsis) and prefixes the email string with a leading space.
E2E Coverage Tracking
.beads/issues.jsonl
Epic ePDS-j448 is added to track E2E coverage implementation for consent and chooser enrichment, including acceptance criteria and scope constraints.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

  • s-adamantine

Poem

🐰 A label takes shape with CSS care,
Ellipsis to trim the email's flair,
A space before text, aligned just right,
And epic tracked for tests in flight! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix(pds-core): add email label spacing' accurately reflects the main change: adding spacing before email labels in the chooser-enrichment component.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch karma/hyper-386-bug-missing-space-between-account-and-email-address

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 7, 2026

@coveralls-official
Copy link
Copy Markdown

Coverage Report for CI Build 25501913634

Coverage remained the same at 55.53%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 2934
Covered Lines: 1624
Line Coverage: 55.35%
Relevant Branches: 1804
Covered Branches: 1007
Branch Coverage: 55.82%
Branches in Coverage %: Yes
Coverage Strength: 5.73 hits per line

💛 - Coveralls

@Kzoeps Kzoeps requested a review from aspiers May 7, 2026 14:45
@aspiers aspiers added this pull request to the merge queue May 7, 2026
Merged via the queue into main with commit cb904e9 May 7, 2026
15 checks passed
@aspiers aspiers deleted the karma/hyper-386-bug-missing-space-between-account-and-email-address branch May 7, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants