Make persistent/temporary/instance keywords target-aware (fixes #1847)#1858
Open
Sukuna0007Abhi wants to merge 1 commit intohyperledger-solang:mainfrom
Open
Make persistent/temporary/instance keywords target-aware (fixes #1847)#1858Sukuna0007Abhi wants to merge 1 commit intohyperledger-solang:mainfrom
Sukuna0007Abhi wants to merge 1 commit intohyperledger-solang:mainfrom
Conversation
hyperledger-solang#1847) Signed-off-by: Sukuna0007Abhi <appsonly310@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1847
PR #1664 added
persistent,temporary, andinstanceas global keywords, which breaksany Solidity code using these as identifiers on non-Soroban targets (e.g.
uint256 persistent = 0;).This fix makes the lexer target-aware, as suggested by @seanyoung. The three words are only
treated as keywords when targeting Soroban, and fall back to plain identifiers for all other targets.
Changes:
solang-parser/src/lexer.rs— addedsoroban: boolflag; keyword lookup skips the three tokens when flag is offsolang-parser/src/lib.rs— addedparse_soroban()alongside existingparse(); shared logic inparse_internal()src/sema/mod.rs— dispatches toparse_soroban()whenns.target == Soroban,parse()otherwisesolang-parser/src/tests.rs— two regression tests: identifiers pass in default, keywords pass in sorobanTesting:
cargo fmt --checkclean