fix: use correct panic code in buffer bounds checks#1859
Open
sakirr05 wants to merge 1 commit intohyperledger-solang:mainfrom
Open
fix: use correct panic code in buffer bounds checks#1859sakirr05 wants to merge 1 commit intohyperledger-solang:mainfrom
sakirr05 wants to merge 1 commit intohyperledger-solang:mainfrom
Conversation
…Generic with PanicCode::ArrayIndexOob (0x32) Signed-off-by: Sakirr <sakirahmed690078@gmail.com>
sakirr05
force-pushed
the
fix/buffer-validator-panic-code
branch
2 times, most recently
from
739d7f0 to
d5f9954
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BufferValidator was emitting Panic(0x00) (Generic) for out-of-bounds reads, but 0x32 (ArrayIndexOob) is what Solidity actually specifies for this case. Debuggers and block explorers use these codes to explain reverts, so the wrong code makes failures harder to trace.
Also cleaned up the two TODO comments that were flagging this.