Skip to content

[ALT-10963] Don't overwrite check_profile from server with an empty string. #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KirillovProj wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −2
Open

[ALT-10963] Don't overwrite check_profile from server with an empty string. #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3766a0d
Don't overwrite `check_profile` from server with an empty string.
KirillovProj Apr 29, 2026
254e4a1
add logging
Tsyklop May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions hs-edu-format/src/org/hyperskill/academy/learning/yaml/YamlMapper.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import org.hyperskill.academy.learning.courseFormat.hyperskill.HyperskillProject
import org.hyperskill.academy.learning.courseFormat.hyperskill.HyperskillStage
import org.hyperskill.academy.learning.courseFormat.hyperskill.HyperskillTopic
import org.hyperskill.academy.learning.courseFormat.tasks.CodeTask
import org.hyperskill.academy.learning.courseFormat.tasks.RemoteEduTask
import org.hyperskill.academy.learning.courseFormat.tasks.Task
import org.hyperskill.academy.learning.courseFormat.tasks.TheoryTask
import org.hyperskill.academy.learning.yaml.format.*
Expand All @@ -31,6 +32,7 @@ import org.hyperskill.academy.learning.yaml.format.hyperskill.HyperskillStageMix
import org.hyperskill.academy.learning.yaml.format.hyperskill.HyperskillTopicMixin
import org.hyperskill.academy.learning.yaml.format.remote.DataTaskAttemptYamlMixin
import org.hyperskill.academy.learning.yaml.format.remote.RemoteCourseYamlMixin
import org.hyperskill.academy.learning.yaml.format.remote.RemoteEduTaskYamlMixin
import org.hyperskill.academy.learning.yaml.format.remote.RemoteStudyItemYamlMixin
import org.hyperskill.academy.learning.yaml.format.student.FeedbackYamlMixin
import org.hyperskill.academy.learning.yaml.format.student.StudentTaskFileYamlMixin
Expand Down Expand Up @@ -87,6 +89,7 @@ object YamlMapper {
addMixIn(Lesson::class.java, LessonYamlMixin::class.java)
addMixIn(FrameworkLesson::class.java, FrameworkLessonYamlMixin::class.java)
addMixIn(Task::class.java, StudentTaskYamlMixin::class.java)
addMixIn(RemoteEduTask::class.java, RemoteEduTaskYamlMixin::class.java)
addMixIn(CodeTask::class.java, CodeTaskYamlMixin::class.java)
addMixIn(TheoryTask::class.java, TheoryTaskYamlUtil::class.java)
addMixIn(CheckFeedback::class.java, FeedbackYamlMixin::class.java)
Expand Down
9 changes: 7 additions & 2 deletions ...-core/src/org/hyperskill/academy/learning/yaml/format/student/StudentTaskChangeApplier.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package org.hyperskill.academy.learning.yaml.format.student

import com.intellij.openapi.application.ApplicationManager
import com.intellij.openapi.diagnostic.logger
import com.intellij.openapi.project.Project
import org.hyperskill.academy.learning.courseFormat.StudyItem
import org.hyperskill.academy.learning.courseFormat.TaskFile
Expand All @@ -11,9 +12,10 @@ import org.hyperskill.academy.learning.messages.EduCoreBundle
import org.hyperskill.academy.learning.yaml.errorHandling.YamlLoadingException
import org.hyperskill.academy.learning.yaml.format.TaskChangeApplier


class StudentTaskChangeApplier(project: Project) : TaskChangeApplier(project) {
private val LOG = logger<StudentTaskChangeApplier>()
override fun applyChanges(existingItem: Task, deserializedItem: Task) {
LOG.info("Applying changes for task: ${existingItem} - ${deserializedItem}")
if (existingItem.solutionHidden != deserializedItem.solutionHidden && !ApplicationManager.getApplication().isInternal) {
throw YamlLoadingException(EduCoreBundle.message("yaml.editor.invalid.visibility.cannot.be.changed"))
}
Expand All @@ -27,7 +29,10 @@ class StudentTaskChangeApplier(project: Project) : TaskChangeApplier(project) {
when (existingItem) {
is EduTask -> {
if (existingItem is RemoteEduTask) {
existingItem.checkProfile = (deserializedItem as RemoteEduTask).checkProfile
val newCheckProfile = (deserializedItem as RemoteEduTask).checkProfile
if (newCheckProfile.isNotEmpty()) {
existingItem.checkProfile = newCheckProfile
}
}
}
}
Expand Down
Loading