feature: intial testing for comparisions between older helm exports#714
Open
Anmol1696 wants to merge 15 commits into
Open
feature: intial testing for comparisions between older helm exports#714Anmol1696 wants to merge 15 commits into
Anmol1696 wants to merge 15 commits into
Conversation
… on writing to file
…ctionality in exposer
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors generated Kubernetes manifests and shell scripts for comparing older Helm exports by:
- Standardizing multiline YAML blocks and consolidating shell commands.
- Injecting new TIME_* and TIMEOUT_* environment variables into statefulsets.
- Aligning
targetPortvalues as integers and introducingtransfer-tokens.shandibc-connection.shhelper scripts.
Reviewed Changes
Copilot reviewed 67 out of 875 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/.../multi-chain/configmaps/setup-scripts.yaml | Reformatted script blocks, added transfer-tokens.sh & ibc-connection.sh. |
| packages/.../multi-chain/cosmoshub/genesis-statefulset.yaml | Added TIME_* and TIMEOUT_* env vars for consensus timeouts. |
| packages/.../full-builders/registry/service.yaml | Changed targetPort quotes to integers, added clusterIP: None. |
Comments suppressed due to low confidence (3)
packages/packages/generator/tests/output/builder-tests/multi-chain/configmaps/setup-scripts.yaml:39
- The loop condition uses the literal string
max_triesinstead of the variable. It should bewhile [[ $max_tries -gt 0 ]]to correctly compare the numeric value.
while [[ max_tries -gt 0 ]]
packages/packages/generator/tests/output/builder-tests/multi-chain/configmaps/setup-scripts.yaml:66
- Similarly here, the loop will not decrement
max_triesproperly. Update towhile [[ $max_tries -gt 0 ]]to reference the variable.
while [[ max_tries -gt 0 ]]
packages/packages/generator/tests/output/builder-tests/full-builders/registry/deployment.yaml:92
- [nitpick] Swapping HTTP-based probes to a TCP socket may mask application-level health issues. Consider retaining an HTTP GET on
/healthif the service provides a health endpoint.
tcpSocket:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of: #695