fix(ci): remove inline heredoc to fix YAML syntax error on L184#116
Conversation
Inline heredocs inside YAML run blocks are unreliable — tabs, blank lines, and EOF markers interact badly with the YAML parser. Move the MUI2 readme.txt content to a static file at .github/windows-installer/readme.txt and copy it in the workflow step instead. No behaviour change; YAML is now valid.
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 26 minutes and 30 seconds.Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Problem
The
<<-'EOF'heredoc inside therun: |block of the Prepare NSIS script and resources step caused a YAML parse error at line 184. Inline heredocs are unreliable in YAMLrunblocks — tabs, blank lines, and theEOFterminator all interact badly with the YAML parser.Fix
Move the
readme.txtcontent out of the workflow entirely. It now lives as a static tracked file at.github/windows-installer/readme.txt. The workflow step simply does:No heredoc, no YAML parsing issue, content is version-controlled and easy to update.
No behaviour change
The file content is identical to what the heredoc was generating. MUI2 still picks it up at
makensiscompile time.