Skip to content

fix(ci): remove inline heredoc to fix YAML syntax error on L184#116

Merged
iamvirul merged 2 commits into
mainfrom
fix/release-yaml-heredoc
May 3, 2026
Merged

fix(ci): remove inline heredoc to fix YAML syntax error on L184#116
iamvirul merged 2 commits into
mainfrom
fix/release-yaml-heredoc

Conversation

@iamvirul

@iamvirul iamvirul commented May 3, 2026

Copy link
Copy Markdown
Owner

Problem

The <<-'EOF' heredoc inside the run: | block of the Prepare NSIS script and resources step caused a YAML parse error at line 184. Inline heredocs are unreliable in YAML run blocks — tabs, blank lines, and the EOF terminator all interact badly with the YAML parser.

Fix

Move the readme.txt content out of the workflow entirely. It now lives as a static tracked file at .github/windows-installer/readme.txt. The workflow step simply does:

cp .github/windows-installer/readme.txt readme.txt

No heredoc, no YAML parsing issue, content is version-controlled and easy to update.

No behaviour change

The file content is identical to what the heredoc was generating. MUI2 still picks it up at makensis compile time.

Inline heredocs inside YAML run blocks are unreliable — tabs, blank
lines, and EOF markers interact badly with the YAML parser. Move the
MUI2 readme.txt content to a static file at
.github/windows-installer/readme.txt and copy it in the workflow step
instead. No behaviour change; YAML is now valid.
@coderabbitai

coderabbitai Bot commented May 3, 2026

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@iamvirul has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 26 minutes and 30 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ae155b14-96df-4b1e-9975-8d168d1cd245

📥 Commits

Reviewing files that changed from the base of the PR and between 7077c90 and f20b640.

📒 Files selected for processing (2)
  • .github/windows-installer/readme.txt
  • .github/workflows/release.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/release-yaml-heredoc

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 26 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@iamvirul iamvirul changed the base branch from feature/macos-pkg-installer to main May 3, 2026 14:19
@iamvirul iamvirul merged commit 04d16ac into main May 3, 2026
14 checks passed
@codecov

codecov Bot commented May 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant