Skip to content

IBX-11423: added optional parameter to urlAliasService:load() call.#1864

Open
papcio122 wants to merge 2 commits into4.6from
IBX-11423_cant-delete-product-urlalias-for-translations
Open

IBX-11423: added optional parameter to urlAliasService:load() call.#1864
papcio122 wants to merge 2 commits into4.6from
IBX-11423_cant-delete-product-urlalias-for-translations

Conversation

@papcio122
Copy link
Copy Markdown
Contributor

@papcio122 papcio122 commented Mar 26, 2026 •
edited
Loading

🎫 Issue IBX-11423

Related PRs:

Description:

Used the optional parameter $showAllTranslations to URLAliasService::load() when deleting URLAlias, which allowed the deletion of URLAlias for translations of contents.

@papcio122 papcio122 mentioned this pull request Mar 26, 2026
Open
@papcio122 papcio122 force-pushed the IBX-11423_cant-delete-product-urlalias-for-translations branch from ad0b679 to 202f807 Compare March 31, 2026 07:21
@papcio122 papcio122 added the Bug Something isn't working label Apr 3, 2026
@papcio122 papcio122 force-pushed the IBX-11423_cant-delete-product-urlalias-for-translations branch from 19bd33d to e6bc0ef Compare April 3, 2026 21:20
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 3, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@papcio122 papcio122 marked this pull request as ready for review April 8, 2026 07:59
@papcio122 papcio122 requested a review from a team April 8, 2026 07:59
konradoboza
konradoboza reviewed Apr 8, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@konradoboza konradoboza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why such change? It seems unrelated to products at first glance, why targeting AdminUI?

@papcio122
Copy link
Copy Markdown
Contributor Author

papcio122 commented Apr 28, 2026 •
edited
Loading

Why such change? It seems unrelated to products at first glance, why targeting AdminUI?

The issue is not only related to products - I updated the ticket and PR description.

When loading a list of aliases to remove in Ibexa\Bundle\AdminUi\Controller\UrlAliasController::removeAction(), the service loads only aliases in the default language; the aliases for translations can't be removed. Changed the call to service so it loads aliases in all languages, so the aliases for translations are also getting added to the remove list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@konradoboza konradoboza konradoboza left review comments

@mikadamczyk mikadamczyk Awaiting requested review from mikadamczyk

@Steveb-p Steveb-p Awaiting requested review from Steveb-p

@alongosz alongosz Awaiting requested review from alongosz

@ciastektk ciastektk Awaiting requested review from ciastektk

@ViniTou ViniTou Awaiting requested review from ViniTou

@barw4 barw4 Awaiting requested review from barw4

@wiewiurdp wiewiurdp Awaiting requested review from wiewiurdp

@tbialcz tbialcz Awaiting requested review from tbialcz

Assignees

@mikadamczyk mikadamczyk

@ciastektk ciastektk

@dew326 dew326

@ViniTou ViniTou

Labels

Bug Something isn't working Ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@papcio122 @konradoboza @mikadamczyk @ciastektk @dew326 @ViniTou