IBX-11694: Corrected condition for DisableSiteRootCheckboxIfRootLocationListener #1896
Open
mateuszdebinski wants to merge 1 commit into5.0from
Open
IBX-11694: Corrected condition for DisableSiteRootCheckboxIfRootLocationListener #1896mateuszdebinski wants to merge 1 commit into5.0from
mateuszdebinski wants to merge 1 commit into5.0from
Conversation
ibexa-workflow-automation-1
Bot
requested review from
Steveb-p,
ViniTou,
alongosz,
barw4,
bnowak,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
|
Contributor
|
@mateuszdebinski the PR's title says absolutely nothing about the fix itself, please adjust it to be more informative. 😉 |
mateuszdebinski
changed the title
mateuszdebinski
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
In v4.6 we have this condition:
if (null !== $location && 1 >= $location->depth)But after changes, the second condition was not correctly converted, now these two 'If' are identical condition