Skip to content

IBX-10734: simplexml_load_string() throws an exception on ezselection fields when using libxml2 2.13.8 and higher #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alongosz merged 7 commits into from
May 5, 2026
Merged

IBX-10734: simplexml_load_string() throws an exception on ezselection fields when using libxml2 2.13.8 and higher #706

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c470e1a
added isset check on simplexml_load_string
Sztig Jan 26, 2026
9d2c980
phpstan fix
Sztig Jan 26, 2026
69acb82
added test coverage for multilingualData with an empty ml
Sztig Apr 9, 2026
ff53721
implemented suggested changes
Sztig Apr 9, 2026
5ee99f1
implemented suggested changes
Sztig Apr 9, 2026
a1ec70f
removed stale phpstan errors, fixed typing in a test
Sztig May 5, 2026
f2e5010
[PHPStan] Added unresolved issue to PHP 7.4 baseline
alongosz May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/Persistence/Legacy/Content/FieldValue/Converter/SelectionConverter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ public function toFieldDefinition(StorageFieldDefinition $storageDef, FieldDefin
}

foreach ($storageDef->multilingualData as $languageCode => $mlData) {
$xml = simplexml_load_string($mlData->dataText);
$xml = $mlData->dataText ? simplexml_load_string($mlData->dataText) : false;
if ($xml !== false) {
foreach ($xml->options->option as $option) {
$multiLingualOptions[$languageCode][(int)$option['id']] = (string)$option['name'];
Expand Down
38 changes: 38 additions & 0 deletions tests/lib/Persistence/Legacy/Content/FieldValue/Converter/SelectionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
use Ibexa\Contracts\Core\Persistence\Content\Type\FieldDefinition as PersistenceFieldDefinition;
use Ibexa\Core\FieldType\FieldSettings;
use Ibexa\Core\Persistence\Legacy\Content\FieldValue\Converter\SelectionConverter;
use Ibexa\Core\Persistence\Legacy\Content\MultilingualStorageFieldDefinition;
use Ibexa\Core\Persistence\Legacy\Content\StorageFieldDefinition;
use Ibexa\Core\Persistence\Legacy\Content\StorageFieldValue;
use PHPUnit\Framework\TestCase;
Expand Down Expand Up @@ -325,6 +326,43 @@ public function testToFieldDefinitionSingleEmpty()

$this->assertEquals($expectedFieldDefinition, $actualFieldDefinition);
}

public function testToFieldDefinitionWithMultilingualDataSkipsEmptyDataText(): void
{
$storageFieldDefinition = new StorageFieldDefinition();
$storageFieldDefinition->dataInt1 = 1;
$storageFieldDefinition->dataText5 = <<<EOT
<?xml version="1.0" encoding="utf-8"?>
<ezselection><options><option id="0" name="First"/></options></ezselection>
EOT;

$mlDataEmpty = new MultilingualStorageFieldDefinition();
$mlDataEmpty->dataText = '';

$mlDataValid = new MultilingualStorageFieldDefinition();
$mlDataValid->dataText = <<<EOT
<?xml version="1.0" encoding="utf-8"?>
<ezselection><options><option id="0" name="Premier"/></options></ezselection>
EOT;

$storageFieldDefinition->multilingualData = [
'eng-GB' => $mlDataEmpty,
'fre-FR' => $mlDataValid,
];

$actualFieldDefinition = new PersistenceFieldDefinition(
[
'mainLanguageCode' => 'eng-GB',
]
);

$this->converter->toFieldDefinition($storageFieldDefinition, $actualFieldDefinition);

$fieldSettings = $actualFieldDefinition->fieldTypeConstraints->fieldSettings;
Comment thread
konradoboza marked this conversation as resolved.

self::assertSame([0 => 'First'], $fieldSettings['multilingualOptions']['eng-GB']);
self::assertSame([0 => 'Premier'], $fieldSettings['multilingualOptions']['fre-FR']);
}
}

class_alias(SelectionTest::class, 'eZ\Publish\Core\Persistence\Legacy\Tests\Content\FieldValue\Converter\SelectionTest');
Loading