Skip to content

IBX-11610: Images with width="" or height="" in xml definition will cause crash #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vidarl wants to merge 1 commit into
base: 5.0
Choose a base branch
from
Open

IBX-11610: Images with width="" or height="" in xml definition will cause crash #745

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/lib/FieldType/Image/Type.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,12 +438,12 @@ public function fromPersistenceValue(FieldValue $fieldValue)
'imageId' => (isset($fieldValue->data['imageId'])
? $fieldValue->data['imageId']
: null),
'width' => (isset($fieldValue->data['width'])
'width' => ($fieldValue->data['width'] ?? '') !== ''
Copy link
Copy Markdown
Contributor Author

@vidarl vidarl Apr 15, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be the most convenient place to do this check, but is this the correct place to add it?
Alternatives are:

? $fieldValue->data['width']
: null),
'height' => (isset($fieldValue->data['height'])
: null,
'height' => ($fieldValue->data['height'] ?? '') !== ''
? $fieldValue->data['height']
: null),
: null,
'additionalData' => $fieldValue->data['additionalData'] ?? [],
'mime' => $fieldValue->data['mime'] ?? null,
]
Expand Down
Loading