Added events (show, cancel and select) as well as some ways to customize the datepicker's input#1
Open
dadisn wants to merge 5 commits intoicaliman:masterfrom
Open
Added events (show, cancel and select) as well as some ways to customize the datepicker's input#1dadisn wants to merge 5 commits intoicaliman:masterfrom
dadisn wants to merge 5 commits intoicaliman:masterfrom
Conversation
— Added “divClass” argument to the component, which can be used to pass CSS classes to the div containing the datepicker input — Added “inputClass” argument to the component, which can be used to pass CSS classes to the datepicker’s input element — Added option to input the datepicker tag’s content (i.e. @content) before the input. This can be used to add labels or Bootstrap add-ons to the input.
Added three events to the datepicker component: — show: Triggered when the datepicker is shown — cancel: Triggered when the datepicker is closed without selecting a date — select: Triggered when a new date has been selected
This was a bad idea, rather just emit an event when select has finished running and provide the previous date as an argument. That way users can revert to the old date if needed for some reason.
… selects a new date
This is to prevent datepickers from firing the “cancel” all the time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commit messages for further details.