fix(stores): add LIMIT clause to DELETE statements in lookup functions#98
Merged
fix(stores): add LIMIT clause to DELETE statements in lookup functions#98
Conversation
mroderick
force-pushed
the
feature/add-delete-limit
branch
from
8005a9a to
7169914
Compare
Deploying idempot-js with
|
| Latest commit: |
bc03c18
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4ae7a224.idempot-js.pages.dev |
| Branch Preview URL: | https://feature-add-delete-limit.idempot-js.pages.dev |
mroderick
force-pushed
the
feature/add-delete-limit
branch
2 times, most recently
from
5b3c540 to
1d89afe
Compare
mroderick
force-pushed
the
feature/add-delete-limit
branch
from
1d89afe to
bc03c18
Compare
mroderick
changed the title
|
🎉 This PR is included in version 1.0.6 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.6 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.6 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add LIMIT 10 to the DELETE statements that remove expired records in all SQL store implementations. This prevents the lookup function from taking a long time when there are many expired records to clean up.
Changes
Notes