Handle TODO that needed new API - #410
Closed
tim-hoffman wants to merge 198 commits into
Closed
Conversation
* [fix upstream] Comment out failing tests * [fix upstream] use different paths to avoid flaky test failure * [fix upstream] fix/hide warnings * [fix upstream] add debug output for ProgramArchive
* add nix flake * add LLZK dependencies * add llzk output flag * add testing framework * Add '--dump_parse' flag for dev and use it for e2e test * add CI workflow
* remove redundant dependency `llzk` already brings in `llzk-sys` and other necessary crates * update dependency version
…#153) * refactor to support lints and clippy restrict clippy to just llzk backend by running `cargo clippy -p llzk_backend -- --no-deps` * fix clippy issues
* also remove undefined "matrix" reference
* fix ineffective "CHECK" lines * add/update tests showing duplication of circom functions per call-site
…nctions within structs (#157)
* fix API-related `todo` * add expected output for tests that now pass
work with Result directly instead of transiting through Option
* Keep track of `poly.expr` types * fixup: add meta location to dimension var stored as `poly.expr` * proper lookup of `poly.expr` for dimension var * move type unification check after the known array case
* Use affine map when parameters differ * Move the prelude generation functions to subcmp.rs for my sanity * Propagate params to compute call * Part of the cleanup * update llzk dependency (#377) * Use new convenience method * Remove test that is not relevant * Second cleanup pass * Emit actual values for the template parameters * Update llzk_backend/src/gen_context.rs Co-authored-by: Timothy Hoffman <4001421+tim-hoffman@users.noreply.github.com> * Fix regression on the input size count * Fix tests * Emit compute call for 0-sized subcomponent only in compute function * Fix tests * Fix regression on template expressions * Fix tests * Pass proper types to parameters * Commented out line * Cleanup imports --------- Co-authored-by: Timothy Hoffman <4001421+tim-hoffman@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.