fix: preserve contradictory constant pin constraints - #424
Draft
NullWitnessZK wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve an explicit contradiction when constant-pin simplification encounters different constants for the same signal.
Given:
the source constraint system is unsatisfiable. Before this change, fast substitutions were inserted into a map keyed by signal, so the later
x = 5substitution overwrotex = 3.-O1dropped one pin and-O2could emit zero constraints.Expected versus current behavior:
Fixes #425. The upstream issue contains the complete standalone reproducer and observed compiler output.
Changes
Validation
cargo test contradictory_constant_pins_are_not_overwritten git diff --checkThe focused test passes. Repository-wide formatting was not applied because the upstream checkout has unrelated pre-existing formatting differences.