Feature/Verify Token V2 - #78
Open
x1m3 wants to merge 6 commits into
Open
Conversation
x1m3
commented
Oct 17, 2024
x1m3
left a comment
x1m3
left a comment
Contributor
Author
There was a problem hiding this comment.
I left some comments .
| github.com/iden3/go-schema-processor/v2 v2.4.0 | ||
| github.com/iden3/iden3comm/v2 v2.5.1 | ||
| github.com/iden3/go-schema-processor/v2 v2.5.0 | ||
| github.com/iden3/iden3comm/v2 v2.7.1-0.20241015160531-d8ea65210731 |
Contributor
Author
There was a problem hiding this comment.
It needs code in iden3/iden3comm#60 that should be accepted, merged and released before accepting this one.
| }, | ||
| }, | ||
| { | ||
| name: "Verify JWZ token, with proof generation delay", |
Contributor
Author
There was a problem hiding this comment.
This test is failing because network inside token is 80001 and there is no resolver for it.
I guess I need a valid token, or to mock eth.Resolvers. To mock eth.Resolvers, we should create a new interface in iden3comm lib for map[int]eth.Resolvers
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First implementation was #76 .
There is some test failing. Need some help here to generate a proper token or to mock eth.Resolver.
This PR needs this iden3/iden3comm#60 merged. Right now it compiles because direct commit is fixed in backend.
I will write some comments by myself in points I need help or I'm not totally happy with it.