OF-3267 chore(deps): bump com.mysql:mysql-connector-j from 8.4.0 to 9.7.0#3296
OF-3267 chore(deps): bump com.mysql:mysql-connector-j from 8.4.0 to 9.7.0#3296dependabot[bot] wants to merge 1 commit into
Conversation
dependabot
Bot
added
dependencies
akrherz
force-pushed
the
dependabot/maven/com.mysql-mysql-connector-j-9.7.0
branch
from
2d67956 to
6cbbcdd
Compare
📝 WalkthroughWalkthroughThe PR updates the MySQL Connector/J JDBC driver dependency from version 8.4.0 to 9.7.0 across two Maven POM files. This is a straightforward dependency version bump with no code logic changes. ChangesMySQL Connector/J Dependency Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Unsure why, but this PR missed bumping in both places like #3307 did |
akrherz
changed the title
akrherz
changed the title
|
https://igniterealtime.atlassian.net/browse/OF-3246 denotes that we may need to pump the brakes on this due to not supporting older MySQL releases. It would be something for 5.1.0 Openfire to consider though... |
akrherz
changed the title
Bumps [com.mysql:mysql-connector-j](https://github.com/mysql/mysql-connector-j) from 8.4.0 to 9.7.0. - [Changelog](https://github.com/mysql/mysql-connector-j/blob/release/9.x/CHANGES) - [Commits](mysql/mysql-connector-j@8.4.0...9.7.0) --- updated-dependencies: - dependency-name: com.mysql:mysql-connector-j dependency-version: 9.7.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
akrherz
force-pushed
the
dependabot/maven/com.mysql-mysql-connector-j-9.7.0
branch
from
6cbbcdd to
649f30f
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@xmppserver/pom.xml`:
- Line 462: The pom.xml change bumps the mysql-connector-java <version> to 9.7.0
which drops support for MySQL 5.7; either revert the dependency to the latest
8.0.x release (restore the previous mysql-connector-java version in the
<version> element for the dependency with artifactId mysql-connector-java) or
move the 9.7.0 upgrade into a breaking-change/major-release branch and document
that Openfire no longer supports MySQL 5.7; update the pom and release notes
accordingly so the project retains 5.7 compatibility unless you intentionally
cut a major release that removes it.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: bb2e4035-e598-43fd-b086-849a0da321e0
📒 Files selected for processing (2)
build/ci/updater/pom.xmlxmppserver/pom.xml
✅ Files skipped from review due to trivial changes (1)
- build/ci/updater/pom.xml
| <groupId>com.mysql</groupId> | ||
| <artifactId>mysql-connector-j</artifactId> | ||
| <version>8.4.0</version> | ||
| <version>9.7.0</version> |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Read-only verification: find documented/supported MySQL versions in this repo
rg -n -C2 --iglob '*.{md,xml,adoc,txt,properties,yml,yaml}' 'MySQL|mysql|MariaDB|OF-3246|connector-j|5\.7|8\.0|8\.4|9\.7'Repository: igniterealtime/Openfire
Length of output: 50379
🌐 Web query:
For MySQL Connector/J 9.7.0, what MySQL Server versions are officially supported? Please use official MySQL documentation/release notes and confirm whether MySQL 5.7 and early 8.0 versions are still supported.
💡 Result:
MySQL Connector/J 9.7.0 officially supports MySQL Server versions 8.0 and higher. It does not support MySQL 5.7 or early 8.0 versions (such as 8.0.0 to 8.0.x prior to full 8.0 stability, but specifically the compatibility is stated as 8.0 and up, excluding 5.7).[1][2]
Citations:
- 1: https://dev.mysql.com/doc/connector-j/en/connector-j-versions.html
- 2: https://dev.mysql.com/doc/relnotes/connector-j/en/news-9-7-0.html
MySQL Connector/J 9.7.0 drops support for MySQL 5.7 and earlier 8.0 versions
Line 462 upgrades the JDBC driver to 9.7.0, which officially supports only MySQL Server 8.0 and higher. This breaks compatibility with any MySQL 5.7 installations. Confirm that Openfire no longer needs to support MySQL 5.7 before merging, or defer this upgrade until a major version release boundary.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@xmppserver/pom.xml` at line 462, The pom.xml change bumps the
mysql-connector-java <version> to 9.7.0 which drops support for MySQL 5.7;
either revert the dependency to the latest 8.0.x release (restore the previous
mysql-connector-java version in the <version> element for the dependency with
artifactId mysql-connector-java) or move the 9.7.0 upgrade into a
breaking-change/major-release branch and document that Openfire no longer
supports MySQL 5.7; update the pom and release notes accordingly so the project
retains 5.7 compatibility unless you intentionally cut a major release that
removes it.
|
MySQL 8.0 is EOL as of last month, might I suggest we take this after Openfire 5.1 branches and target 5.2 ? |
I think that's a good idea. |
2 participants
Bumps com.mysql:mysql-connector-j from 8.4.0 to 9.7.0.
Changelog
Sourced from com.mysql:mysql-connector-j's changelog.
... (truncated)
Commits
0aade1fFix for Bug#119863 (Bug#38951042), Inaccurate decoding of negative TIME durat...b6d5baaUpdate for GPL license book.a7cc5a9Fix for DateTimeTest failures after some of the work done for WL#16669 in MyS...6a0c818WL#17215, Implement JDBC 4.3/4.5 Statement/Connection.enquote* methods.5f96e85Fix for Bug#119245 (Bug#38599240), Select into fix breaks queries with 'into'...8d779fcFix for Bug#119659 (Bug#38916595), BinaryResultsetReader fails to consume EOF...1391179Copyright header year bump.5c764b4Post-release version bump.fdef61fUpdate copyright year.43aced7Update for GPL license book.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Summary by CodeRabbit