make compatible with non-coupling-enabled versions of grudge v3#1048
make compatible with non-coupling-enabled versions of grudge v3#1048
Conversation
f6849d1 to
6bcca49
Compare
|
I don't have a problem with anything being done here, except the hamstringing of the prediction tests. If prediction tests can't be run, then nothing can stop us from checking things in that break prediction - which has caused us great trouble multiple times in the not-too-distant past. |
Just to clarify, this PR currently includes changing the |
Ah, I see now. So is the plan that external packages can do their "upstream mirgecom tests" in CI by using |
Yes, |
I don't think it can be "or". Upstream pkg's dowstream mirgecom tests should include the examples, at least, if not exclusively. |
|
This is ready for review. The Production CI error is due to a merge issue. |
Followup of #898.
TODO:
needs Restore loop inference fallback inducer/arraycontext#269main(undo 596894d)Questions for the review: