Skip to content

Enable CFL and DT #368

Merged
MTCam merged 157 commits intomainfrom
enable-cfl-and-dt
Jul 13, 2021
Merged

Enable CFL and DT #368
MTCam merged 157 commits intomainfrom
enable-cfl-and-dt

Conversation

@MTCam
Copy link
Copy Markdown
Member

@MTCam MTCam commented May 28, 2021 •
edited
Loading

With this changeset we pick up grudge's new characteristic_lengthscales interface to get CFL and maximum stable DT estimates. This enables the existing infrastructure in MIRGE-Com for:

  • Constant DT mode:
    • Fixed timestep, variable CFL
    • CFL tracking and reporting
    • Cell-local CFL visualization
  • Constant CFL mode:
    • Variable timestep, fixed CFL
    • DT tracking and reporting
    • Cell-local maximum stable DT visualization

@MTCam MTCam requested a review from thomasgibson May 28, 2021 16:51
inducer
inducer reviewed May 28, 2021
View reviewed changes
Comment thread mirgecom/inviscid.py Outdated
@MTCam MTCam added enhancement New feature or request y1 Flowing down to Y1 production labels Jun 4, 2021
thomasgibson
thomasgibson reviewed Jun 5, 2021
View reviewed changes
Comment thread mirgecom/inviscid.py Outdated
Comment thread mirgecom/simutil.py
MTCam and others added 20 commits July 9, 2021 11:35
@MTCam
Satisfy pylint to raise an actual named exception inside try.
c544ddd
@MTCam @majosm
Fix up the documentation to have the correct signature for callbacks
810ab46 
Co-authored-by: Matt Smith <mjsmith6@illinois.edu>
@MTCam
Massage exceptions a bit so that the error messages are a little more…
549a8dd 
… informative, cleaner.
@MTCam
Merge branch 'exceptions-massage' into recallbacks
d51755a
@MTCam
Rearrange function def order for consistency and less "tism" activation.
af009c3
@MTCam
Tweak exception handling to our liking.
5306e30
@MTCam
Add syncing utility and use it in examples.
5bd30d8
@MTCam
Merge with recallbacks
d45d81a
@MTCam
Notify of which examples failed.
56df2d8
@MTCam
Merge branch 'main' into enable-cfl-and-dt
2210715
@MTCam
Fix merge error
53a220d
@MTCam
Clean up a couple of drivers, move toward constant cfl support
f781d80
@MTCam
add missing arg to write_vis
b8114cd
@MTCam
Remove superfluous constant CFL example.
c523fa4
@MTCam
Clean up, succinctify some of the interfaces, add cfl to viz interface.
c68f1e4
@MTCam
Rarrange cosmetically into logical sections, use simutil timestep util.
a3250f4
@MTCam
Use simutil timestep util, clean up restart handling, some cosmetics
5d373ac
@MTCam
Rename the timestepping interface, add note about viscous
71d74f8
@MTCam
Clean up examples a bit, massage timestepping control for constant CF…
07fa272 
…L mode
@MTCam
Correct health call.
59fc7a4
thomasgibson
thomasgibson reviewed Jul 12, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@thomasgibson thomasgibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments. Thanks for seeing this to the end!

Comment thread mirgecom/simutil.py Outdated
Comment thread mirgecom/inviscid.py Outdated
Comment thread examples/autoignition-mpi.py Outdated
thomasgibson
thomasgibson reviewed Jul 13, 2021
View reviewed changes
Comment thread .ci-support/production-setup.sh
@MTCam MTCam merged commit 09c86ee into main Jul 13, 2021
@MTCam MTCam deleted the enable-cfl-and-dt branch July 13, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@inducer inducer inducer left review comments

@majosm majosm majosm left review comments

+2 more reviewers

@thomasgibson thomasgibson thomasgibson approved these changes

@cmikida2 cmikida2 cmikida2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request y1 Flowing down to Y1 production

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MTCam @inducer @majosm @thomasgibson @cmikida2