Skip to content

Port THGs limiter to main#601

Closed
MTCam wants to merge 5 commits intomainfrom
thg-limiter
Closed

Port THGs limiter to main#601
MTCam wants to merge 5 commits intomainfrom
thg-limiter

Conversation

@MTCam
Copy link
Copy Markdown
Member

@MTCam MTCam commented Feb 1, 2022

Attempt to port #591 from #551 to main.

Questions for the review:

  • Is the scope and purpose of the PR clear?
    • The PR should have a description.
    • The PR should have a guide if needed (e.g., an ordering).
  • Is every top-level method and class documented? Are things that should be documented actually so?
  • Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
  • Does the implementation do what the docstring claims?
  • Is everything that is implemented covered by tests?
  • Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?

@tulioricci tulioricci mentioned this pull request Apr 4, 2023
8 tasks
@MTCam MTCam closed this Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant