Skip to content

Add optional user-specified comm_tag to operators#741

Merged
majosm merged 2 commits intoillinois-ceesd:mainfrom
majosm:user-comm-tag
Sep 7, 2022
Merged

Add optional user-specified comm_tag to operators#741
majosm merged 2 commits intoillinois-ceesd:mainfrom
majosm:user-comm-tag

Conversation

@majosm
Copy link
Copy Markdown
Collaborator

@majosm majosm commented Sep 2, 2022

...for disambiguating multiple operator calls within a single compiled function.

Questions for the review:

  • Is the scope and purpose of the PR clear?
    • The PR should have a description.
    • The PR should have a guide if needed (e.g., an ordering).
  • Is every top-level method and class documented? Are things that should be documented actually so?
  • Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
  • Does the implementation do what the docstring claims?
  • Is everything that is implemented covered by tests?
  • Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?

Copy link
Copy Markdown
Member

@MTCam MTCam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat solution.

@majosm
Copy link
Copy Markdown
Collaborator Author

majosm commented Sep 2, 2022

(Verified in the multiple-volumes-mpi.py example of #726.)

@matthiasdiener @inducer Does this look OK to you guys?

@majosm majosm marked this pull request as ready for review September 2, 2022 20:04
@inducer
Copy link
Copy Markdown
Contributor

inducer commented Sep 7, 2022

LGTM. Two thoughts I had while scrolling:

@majosm majosm merged commit d9fceff into illinois-ceesd:main Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants