Skip to content

Refactor diffusion to look more like Euler/NS#744

Merged
majosm merged 3 commits intoillinois-ceesd:mainfrom
majosm:refactor-diffusion-quadrature
Sep 13, 2022
Merged

Refactor diffusion to look more like Euler/NS#744
majosm merged 3 commits intoillinois-ceesd:mainfrom
majosm:refactor-diffusion-quadrature

Conversation

@majosm
Copy link
Copy Markdown
Collaborator

@majosm majosm commented Sep 7, 2022

Split out from #726. Pulls the quadrature projection stuff up out of the flux and boundary functions.

Questions for the review:

  • Is the scope and purpose of the PR clear?
    • The PR should have a description.
    • The PR should have a guide if needed (e.g., an ordering).
  • Is every top-level method and class documented? Are things that should be documented actually so?
  • Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
  • Does the implementation do what the docstring claims?
  • Is everything that is implemented covered by tests?
  • Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?

MTCam Review:

  • Is the scope and purpose of the PR clear?
    • The PR should have a description.
    • The PR should have a guide if needed (e.g., an ordering).
  • Is every top-level method and class documented? Are things that should be documented actually so?
  • Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
  • Does the implementation do what the docstring claims?
  • Is everything that is implemented covered by tests?
  • Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?

@majosm majosm marked this pull request as ready for review September 12, 2022 14:54
@majosm majosm requested a review from MTCam September 12, 2022 14:54
Copy link
Copy Markdown
Member

@MTCam MTCam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward refactor 👍

@majosm majosm merged commit 054ca1b into illinois-ceesd:main Sep 13, 2022
@majosm majosm mentioned this pull request Sep 13, 2022
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants