Fix Deeper Darker 1.4 compatibility - #178
Open
F0x06 wants to merge 1 commit into
Open
Conversation
DeeperDarkerConfig.soulElytraCooldown was moved into a CONFIG holder in 1.4, which broke our integration with a NoSuchFieldError at runtime. Switch to the new accessor and bump the compileOnly dependency.
|
Is this going to be updated and pushed to CurseForge? |
|
Really hope this can be pushed and the build uploaded at some point. |
|
My server is encountering this issue when generating a specific chunk, crashing the entire server. Anyone able to build version of the mod with this change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DeeperDarkerConfig.soulElytraCooldownwas moved into aCONFIGholder in 1.4, which broke our integration with aNoSuchFieldErrorat runtime. Switch to the new accessor and bump thecompileOnlydependency.Note (not in this PR): to get the project to compile locally on Java 21 I also had to:
net.darkhax.curseforgegradlefrom'1.+'to'1.1.28'in the loaderbuild.gradlefiles — version1.2.30was published on 2026-03-26 targeting Java 25, so the floating1.+resolves to a plugin Gradle 8.8 / Java 21 can no longer load.token = findProperty('modrinthKey') ?: 0to?: ''in themodrinth { }blocks — the Integer fallback fails the typedString tokenproperty check on the current Modrinth Minotaur plugin.I left those out of this PR to keep the diff focused on the actual bug fix, but happy to follow up with a separate PR if you'd like them addressed too.