[codex] Sync avatar settings across Linux windows#954
Conversation
Yo-DDV
left a comment
There was a problem hiding this comment.
Thanks @Ikkisovi for keeping this focused.
@ilysenko, I traced the complete path rather than relying only on the fixture. The avatar overlay is registered through the same app-service window manager, messages are queued while a renderer is not ready, and the receiving path only invalidates the requested query. I found no rebroadcast loop or window lifecycle mismatch.
I also applied the patch twice against the current upstream 26.707.62119 main bundle. It inserted one marker, emitted no warning, parsed successfully, and the second pass was byte-identical. The patcher suite passes 369/369 and the script smoke suite passes. The payload matches the existing desktop-originated invalidations for skills and plugins, with no new external I/O, dependency, or permission surface.
I found no blocker in the changed code or the adjacent IPC and window lifecycle paths.
ilysenko
left a comment
There was a problem hiding this comment.
The repository now targets upstream CODEX.DMG version 26.707.71524, while this PR was validated against 26.707.62119.
Please rebase onto the current main and verify that the patch still matches and works against the current DMG. Follow the repository’s CONTRIBUTING.md, run the relevant tests locally, review the complete diff independently with a local LLM, and wait for all required CI checks to pass before requesting maintainer review or merge.
e4ed986 to
afa0d06
Compare
afa0d06 to
971ddda
Compare
|
Addressed the requested changes:
I will wait for all required CI checks to pass before requesting maintainer review or merge. GitHub currently reports no checks for the updated fork head. If the workflows are waiting for first-time contributor approval, maintainer workflow approval is needed before those required checks can start. |
Summary
query-cache-invalidateevents to every registered Electron windowRoot Cause
The settings window optimistically updates its own cache and persists the value, but the avatar overlay is a separate renderer with an independent settings cache. The existing internal IPC broadcast does not deliver to sibling Electron windows, so the overlay retained its startup value until restart.
Scope
This is Linux-only wrapper behavior. It does not change the settings schema, skill staging, Ozone mode, Wayland behavior, window positioning, or drag handling.
Current Upstream Validation
mainat52e970126.707.7222140e34814e74e30943c209ebd4da94cd4de3581a52c5bffbe2bcf2e488d6361c6main-UDW_FlxC.js, Electron42.1.0acceptedlinux-avatar-settings-sync=applied, strategy =upstreamTests
node --test scripts/patch-linux-window-ui.test.js(385/385passed)bash tests/scripts_smoke.sh(passed)git diff --check(passed)Required CI checks will be allowed to complete before maintainer review or merge is requested.