Match Linux desktop settings to native styling#979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The generated Linux settings fallback components still used an older layout and a custom inline switch palette. After the Settings runtime moved to self-contained generated controls, those values no longer tracked the current native component contract, so Linux desktop looked visually separate from the rest of Settings and enabled switches could render with the wrong theme color.
Runtime validation
Validated side-by-side on KDE Plasma Wayland with:
40e34814e74e30943c209ebd4da94cd4de3581a52c5bffbe2bcf2e488d6361c60x8DEE17F53C306BB615731826bytesThe Linux desktop page now uses the same panel width, typography, row spacing, borders, active switch color, thumb position, and pointer cursor as General. No error boundary or console errors were observed.
Tests
node --test scripts/patch-linux-window-ui.test.jsnode --test linux-features/*/test.jsbash tests/scripts_smoke.shnode --checkon all generated Linux settings assetsgit diff --check