Skip to content

Match Linux desktop settings to native styling#979

Merged
ilysenko merged 2 commits into
ilysenko:mainfrom
PinguuSS:build/fix-linux-settings-theme
Jul 15, 2026
Merged

Match Linux desktop settings to native styling#979
ilysenko merged 2 commits into
ilysenko:mainfrom
PinguuSS:build/fix-linux-settings-theme

Conversation

@PinguuSS

Copy link
Copy Markdown
Contributor

Summary

  • align the generated Linux settings page, sections, groups, and rows with the current native Settings layout
  • replace the custom inline switch styling with the current theme-token and state-class contract
  • keep the generated controls self-contained while matching upstream spacing, typography, colors, borders, and interaction cursor

Root cause

The generated Linux settings fallback components still used an older layout and a custom inline switch palette. After the Settings runtime moved to self-contained generated controls, those values no longer tracked the current native component contract, so Linux desktop looked visually separate from the rest of Settings and enabled switches could render with the wrong theme color.

Runtime validation

Validated side-by-side on KDE Plasma Wayland with:

  • ChatGPT Desktop 26.707.72221
  • Electron 42.1.0
  • DMG SHA-256: 40e34814e74e30943c209ebd4da94cd4de3581a52c5bffbe2bcf2e488d6361c6
  • DMG ETag: 0x8DEE17F53C306BB
  • DMG size: 615731826 bytes

The Linux desktop page now uses the same panel width, typography, row spacing, borders, active switch color, thumb position, and pointer cursor as General. No error boundary or console errors were observed.

Tests

  • node --test scripts/patch-linux-window-ui.test.js
  • node --test linux-features/*/test.js
  • bash tests/scripts_smoke.sh
  • node --check on all generated Linux settings assets
  • isolated current-DMG rebuild and patch-report acceptance
  • git diff --check

@PinguuSS PinguuSS marked this pull request as ready for review July 14, 2026 20:05

@ilysenko ilysenko left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed current head fe78ef5. The Linux Settings fallback styling change is focused, covered by patcher/current-DMG checks, and I found no blockers.

@ilysenko ilysenko merged commit 42a2d70 into ilysenko:main Jul 15, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants