revisited the DefaultLegacyOpener, added support for SelfShowableContent#302
Open
xulman wants to merge 1 commit intoimagej:mainfrom
Open
revisited the DefaultLegacyOpener, added support for SelfShowableContent#302xulman wants to merge 1 commit intoimagej:mainfrom
xulman wants to merge 1 commit intoimagej:mainfrom
Conversation
...which is a new kind of result of opening of inputs, often used in conjuction with openers that do load-and-show on their own, as opposite to load-only-and-have-Fiji-to-show pattern.
Author
|
this PR works in conjuction with scijava/scijava-common#473 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves two things:
Based on @ctrueden 's commit, it reorganizes the order of actions in the main ImageJ1&2 opening routine such that the routine first makes sure it has a valid argument (which is a "path" to a resource, be it a file on a drive, or URL to somewhere) and only then it continues resolving how that argument
pathis going to be opened. The constraints considered during the opening were preserved, that said, it still honors wether newStyleIO is to be used first or not, falls back to IJ openers, etc.The second change is that it detects when an opener returns
SelfShowableContentas a result of opening the inputpath, and if so, it activates itsshow()method...