Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Docs/contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Alternatively, running `func init` from the function directory will stamp out ev

`func azure functionapp fetch-app-settings <functionName>`

If you don't want to compile and run the `CompressImagesFunction` directly, you can use docker. See the image on [dockerhub](https://hub.docker.com/r/vertigostudio/imgbot-compress).
If you don't want to compile and run the `CompressImagesFunction` directly, you can use docker. See the image on [Docker Hub](https://hub.docker.com/r/vertigostudio/imgbot-compress).

There are a few additional environment settings that need to be set to run the compression workflow. These can be set with `local.settings.json` or any other way

Expand Down Expand Up @@ -127,7 +127,7 @@ Today this is done by combining the name of the repo with a random number.
The 2 main events we deal with through webhooks are installation events and push events.
Each time a repo has Imgbot installed, GitHub fires a hook to `WebHookFunction.cs` and we start the installation workflow.

Each time a repo that already has Imgbot installed gets pushed to, GitHub fires a hook to `WebHookFunction.cs` and, if the commit contains an image update, we start the compression worflow.
Each time a repo that already has Imgbot installed gets pushed to, GitHub fires a hook to `WebHookFunction.cs` and, if the commit contains an image update, we start the compression workflow.

### Imgbot website

Expand Down Expand Up @@ -182,7 +182,7 @@ The template that renders the documentation is [Web/src/docs/layout.jst](https:/

### Tests

Imgbot uses VSTest with NSubstitue to manage unit testing of the logic within the Imgbot codebase.
Imgbot uses VSTest with NSubstitute to manage unit testing of the logic within the Imgbot codebase.
The tests live in the Test directory.
Please do your best to add tests as new features or logic are added so we can keep Imgbot running smoothly.
:)
4 changes: 2 additions & 2 deletions Test/WebHookTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,7 @@ void ExtraSetup(
[TestMethod]
public async Task GivenInstallationDeleted_ShouldReturnOkDropPartition()
{
var mockIntallations = new[]
var mockInstallations = new[]
{
new DynamicTableEntity("654321", "repo1") { ETag = "*" },
new DynamicTableEntity("654321", "repo2") { ETag = "*" },
Expand All @@ -473,7 +473,7 @@ public async Task GivenInstallationDeleted_ShouldReturnOkDropPartition()
var tableQuerySegment = (TableQuerySegment)typeof(TableQuerySegment)
.GetConstructors(BindingFlags.Instance | BindingFlags.NonPublic)
.First(x => x.GetParameters().Count() == 1)
.Invoke(new object[] { mockIntallations });
.Invoke(new object[] { mockInstallations });

void ExtraSetup(
CloudQueue extraRouterMessages,
Expand Down
6 changes: 3 additions & 3 deletions Web/src/app/vue/components/Repository.vue
Original file line number Diff line number Diff line change
Expand Up @@ -135,13 +135,13 @@ export default {
var vm = this;

vm.checking = true;
let requestChangeOptimzationUrl = `${settings.authhost}/api/repositories/check/${vm.installationid}/${vm.current.id}`;
let requestChangeOptimizationUrl = `${settings.authhost}/api/repositories/check/${vm.installationid}/${vm.current.id}`;
if ( changeOptimize === true) {
requestChangeOptimzationUrl += `/${!vm.current.IsOptimized}`;
requestChangeOptimizationUrl += `/${!vm.current.IsOptimized}`;
}
axios
.get(
requestChangeOptimzationUrl,
requestChangeOptimizationUrl,
{
withCredentials: true
}
Expand Down
4 changes: 2 additions & 2 deletions WebHook/WebHookFunction.cs
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ private static async Task<string> ProcessPushAsync(

var shouldAddRouterMessage = true;

// always true if not on the new plan because the check for a private plan would exit at the begining
// always true if not on the new plan because the check for a private plan would exit at the beginning
// if it is on the plans with repository limit we will check if it is a repo that needs to be optimized by using the flag
// no need to check for the limits
// it was checked when the repository flag was added
Expand Down Expand Up @@ -499,7 +499,7 @@ private static async Task<bool> ShouldOptimize(CloudTable installationTable, str
return false;
}

// We are using commit hooks here, so let's deduce whether this is an eligble scenario for auto-deleting a branch
// We are using commit hooks here, so let's deduce whether this is an eligible scenario for auto-deleting a branch
// 1. should be merged using the web gui on github.com
// 2. should be merging into the default branch from the imgbot branch
// 3. should only contain the merge commit and the imgbot commit to be eligible
Expand Down