WIP: add personal_sign - #20
Open
apoorvlathey wants to merge 2 commits into
Open
Conversation
apoorvlathey
force-pushed
the
master
branch
3 times, most recently
from
May 3, 2024 13:00
dd4b6c3 to
602ae43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test dapp: https://react-app.walletconnect.com/
When trying to call
personal_signRPC method, the dapp instantly throws the request failed error, before the injected wallet can sign the message:Most probable reason is
No matching key. session topic doesn't existerror shown on Impersonator when the above request is made: