Conversation
| - uses: actions/checkout@v4 | ||
| with: | ||
| submodules: true | ||
| - uses: astral-sh/setup-uv@v5 |
There was a problem hiding this comment.
Any reason not to use ruff-action? I don't recall why we went with installing it manually when we switched..
There was a problem hiding this comment.
The whole point of this PR is to encode ruff version ranges in pyproject.toml. AFAICT, ruff-action ignores that?
There was a problem hiding this comment.
I don't know if that was the case in the past, but their documentation says they do read pyproject.toml to get the version: https://github.com/astral-sh/ruff-action?tab=readme-ov-file#install-specific-versions
There was a problem hiding this comment.
Eh, I find the version with uv easier to reason about. In addition, the actions thing wouldn't work on Gitlab, so then that would just introduce inconsistency.
| "ply>=3.6", | ||
| ] | ||
|
|
||
| [dependency-groups] |
There was a problem hiding this comment.
What's the benefit for dependency-groups? I haven't looked into it much :(
There was a problem hiding this comment.
Defined in https://peps.python.org/pep-0735/. The PEP describes the design decisions. It seems that dependency groups are the "hot new" way to do dev dependencies. A markedly useful aspect here is that, unlike the usual "extras", they permit only the dev dependencies to be installed, without fully installing loopy.
There was a problem hiding this comment.
they permit only the dev dependencies to be installed
I see why that's quite useful here, thanks :D
2 participants
No description provided.