[3.x] Fix flash event not firing when response contains errors#3038
Merged
pascalbaljet merged 1 commit intoinertiajs:3.xfrom Apr 7, 2026
Merged
[3.x] Fix flash event not firing when response contains errors#3038pascalbaljet merged 1 commit intoinertiajs:3.xfrom
pascalbaljet merged 1 commit intoinertiajs:3.xfrom
Conversation
Member
|
Thanks! |
pascalbaljet
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flash events (
fireFlashEvent,onFlash) were silently dropped when the response also contained validation errors, becauseResponse.process()returned early in the error path before reaching the flash event code.This PR moved flash event firing to happen right after
setPage(), before the error check, so flash data is delivered regardless of whether errors are present.