Skip to content

fix: default proxy setting and setup bootstrap password check#291

Open
luohoufu wants to merge 1 commit intomainfrom
fix_setup
Open

fix: default proxy setting and setup bootstrap password check#291
luohoufu wants to merge 1 commit intomainfrom
fix_setup

Conversation

@luohoufu
Copy link
Copy Markdown
Contributor

What does this PR do

Rationale for this change

Standards checklist

  • The PR title is descriptive
  • The commit messages are semantic
  • Necessary tests are added
  • Updated the release notes
  • Necessary documents have been added if this is a new feature
  • Performance tests checked, no obvious performance degradation

@luohoufu luohoufu requested review from SteveLauC and medcl April 12, 2026 00:13
Comment thread plugin/setup/setup.go
}

if !util.ValidateSecure(request.BootstrapPassword) {
if request.BootstrapPassword != "" && !util.ValidateSecure(request.BootstrapPassword) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is request.BootstrapPassword allowed to be empty?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reinit when password already setting by last time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants